Skip to content
This repository has been archived by the owner on Feb 13, 2021. It is now read-only.

Commit

Permalink
Merge pull request #20 in AOLP_ADS_JS/prebid.js from bug/auction_id_m…
Browse files Browse the repository at this point in the history
…ax_byte_length to release/1.0.6

* commit '8970b56be22d57ae29858b141a15898442bbd15f':
  Limit action ID max digits to 18, in order to prevent value exceeding 64 bits.
  • Loading branch information
Samuel Adu committed Aug 31, 2016
2 parents 08d50c0 + 8970b56 commit 1f7f807
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
AOL Prebid 1.0.6
----------------
BUGFIX: Ensure that auctionId never exceeds max 64 bit value. Limit length to 18 digits.


AOL Prebid 1.0.5
----------------
BUGFIX: Ensure that an event is logged in the case when there are no bids from the DSPs.
Expand Down
2 changes: 1 addition & 1 deletion src/adapters/analytics/aol.js
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ function generateAuctionId(placementId) {
placementId +
// Random number, 5 digits at the time of development.
Math.floor(Math.random() * 100000)
).substr(0, 19); // Limit to 19 digits so it doesn't exceed the LONG type.
).substr(0, 18); // Limit to 18 digits so it doesn't exceed the LONG type.
}

function getBidderId(bidderCode) {
Expand Down

0 comments on commit 1f7f807

Please sign in to comment.