Remap / rebind keymap to action

[arouene]

Describe the bug
It does not seem possible to remap a kemap (like C-p which is bind to "SelectPreviousOrScrollUp") to an action (like "AddToPlaylist").

To Reproduce
I have this keymap.toml

[[keymaps]]
command = "SelectPreviousOrScrollUp"
key_sequence = "k"

[[actions]]
action = "AddToPlaylist"
key_sequence = "C-p"

Expected behaviour
SelectPreviousOrScrollUp is k
AddToPlaylist is C-p

Environment

• OS: Linux Fedora 40
• Application version: 0.19.1

[arouene]

Besides, why do we make a difference between a keymap and an action?

[aome510]

Besides, why do we make a difference between a keymap and an action?

I think you mean command and action. The difference is that action performs on a specific item (input) while command is supposed to be a general operation w/o input.

[arouene]

Oh ok, I see, thank you !

[aome510]

You can bind C-p to an action by binding C-p to command = "None" to allow re-use the key.

[arouene]

I did try that, but then C-p is just not bind to anything

[[keymaps]]
command = "SelectPreviousOrScrollUp"
key_sequence = "k"

[[keymaps]]
command = "None"
key_sequence = "C-p"

[[actions]]
action = "AddToPlaylist"
key_sequence = "C-p"

[aome510]

I see, then it's bug that doesn't allow to re-use None command. It should be easy to update

spotify-player/spotify_player/src/config/keymap.rs

Line 416 in 58a5ace

if let Some(command) = self.find_command_from_key_sequence(key_sequence) {

to ignore None command.

[arouene]

Fixed in PR