Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to search or lookup artist songs #617

Closed
Saevath opened this issue Nov 27, 2024 · 11 comments · Fixed by #618
Closed

Unable to search or lookup artist songs #617

Saevath opened this issue Nov 27, 2024 · 11 comments · Fixed by #618
Labels
bug Something isn't working

Comments

@Saevath
Copy link

Saevath commented Nov 27, 2024

Describe the bug
Whenever I try to search a song or look up an artist's playlist the player gets stuck, from the logs I can see that the fetch request seems to be failing.

To Reproduce
Install spotify-player
Authenticate
Try to search a song title or artist

Expected behaviour
View the searched songs

Log and backtrace
2024-11-27T21:43:17.059424Z INFO client_request{request=GetContext(Artist(ArtistId("2d0hyoQ5ynDBnkvAbJKORj")))}: spotify_player::client: Get artist context: spotify:artist:2d0hyoQ5ynDBnkvAbJKORj
2024-11-27T21:43:17.326311Z ERROR client_request{request=GetContext(Artist(ArtistId("2d0hyoQ5ynDBnkvAbJKORj")))}: spotify_player::client::handlers: Failed to handle client request: get related artists: http error: status code 404 Not Found

Screenshots
N/A

Environment

  • OS: Arch Linux
  • Application version: 0.20.1
  • Application features: pulseaudio-backend,streaming,image,notify

Additional context
N/A

@Saevath Saevath added the bug Something isn't working label Nov 27, 2024
@Saevath
Copy link
Author

Saevath commented Nov 27, 2024

Something similar also happens when I start the application, nothing shows in the Playback and from the log I can see this:

2024-11-27T21:53:10.385492Z ERROR librespot_connect::spirc: ContextError: Error { kind: NotFound, error: StatusCode(404) }
2024-11-27T21:53:10.385518Z INFO librespot_connect::spirc: No more tracks left in queue
2024-11-27T21:53:10.453908Z ERROR librespot_connect::spirc: ContextError: Error { kind: NotFound, error: StatusCode(404) }

@yawnbo
Copy link

yawnbo commented Nov 27, 2024

Same issues, this happens when searching

2024-11-27T23:31:48.533617Z ERROR client_request{request=Search("blah blah")}: spotify_player::client::handlers: Failed to handle client request: json parse error: invalid type: null, expected struct SimplifiedPlaylist at line 1 column 8664: invalid type: null, expected struct SimplifiedPlaylist at line 1 column 8664

User playlists still work and appear but new playlists that were made recently aren't appended due to

2024-11-27T23:31:35.293265Z ERROR client_request{request=GetUserPlaylists}: spotify_player::client::handlers: Failed to handle client request: invalid type: null, expected struct SimplifiedPlaylist at line 1 column 4901

@j-danner
Copy link

j-danner commented Nov 28, 2024

I have the exact same issue...

Might this be related to recent the changes in the web API?

https://developer.spotify.com/blog/2024-11-27-changes-to-the-web-api

@ociton
Copy link

ociton commented Nov 28, 2024

I also gave the exact same issue

Arch, spotify-player-pipewire from aur

@aome510
Copy link
Owner

aome510 commented Nov 28, 2024

Can confirm that I also got many 404 errors. Might be related to the new Spotify API changes. Spotify always breaks their APIs 🤦 . I'll take a look over the weekend to see how to fix/mitigate this issue.

@aome510 aome510 pinned this issue Nov 28, 2024
@bartlibert
Copy link

For me, it works fine if I use the default client_id.
If I use my own one, it's broken.
Seems consistent with the changes introduced in the api, as my own app is still "in development" and as such is considered a "new" app that has no access to the relevant web API access points.
So I have to choose now: spotify connect or searching...

@aome510
Copy link
Owner

aome510 commented Nov 29, 2024

one thing I just found out is that this 404 error only happens if you use your own client_id, i.e. to set up Spotify Connect. In other words, to work-around this issue, you can unset client_id in your app.toml to use the default Spotify client_id

I feel like this can be worked around further by implementing a separate client just for Spotify Connect, which I will play around over the weekend

@Saevath
Copy link
Author

Saevath commented Nov 30, 2024

I can confirm that using the default Spotify client_id has fixed the issue for me.

@aome510
Copy link
Owner

aome510 commented Nov 30, 2024

Should be fixed with #618. Can anyone try latest master and confirm it's the case?

@IdoEsports
Copy link

Should be fixed with #618. Can anyone try latest master and confirm it's the case?

Great work! Works perfectly on mac os after building master.

@ociton
Copy link

ociton commented Dec 1, 2024

when will it be merged into aur package?

@aome510 aome510 unpinned this issue Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants