This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: nvd3 charts break on stateChange dispatch #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
Jul 29, 2019
| @@ -654,7 +654,9 @@ function nvd3Vis(element, props) { | |||
| applyYAxisBounds(); | |||
|
|
|||
| // Also reapply on each state change to account for enabled/disabled series | |||
| chart.dispatch.on('stateChange.applyYAxisBounds', applyYAxisBounds); | |||
| if (chart.dispatch && chart.dispatch['stateChange']) { | |||
There was a problem hiding this comment.
chart.dispatch.stateChange?
etr2460
force-pushed
the
erik-ritter--more-y-axis
branch
from
ebc69f0 to
92613ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
======================================
Coverage 25.9% 25.9%
======================================
Files 8 8
Lines 166 166
Branches 10 10
======================================
Hits 43 43
Misses 122 122
Partials 1 1Continue to review full report at Codecov.
|
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
The change in #148 broke charts that don't have a
stateChangedispatch event like the box plot. This fixes the issue.Tested by opening all the charts (including box plot) in storybook and seeing them render
@kristw