This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: list css as side effects #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khtruong
approved these changes
Apr 12, 2019
|
wow that's tricky, nice fix 👍 |
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
feat: Add ChartClient
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
lexisstv
pushed a commit
to utrace-ltd/superset-ui-plugins
that referenced
this pull request
Jun 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Problem
related to apache/superset#7058
The root cause ends up being the
sideEffects: truethat is set in eachpackage.json.webpackinproductionmode uses this to determine if the package has any side effects and when it is declaredfalse, it (via treeshaking) drops the file that does not export anything, includingcss. Treeshaking only applies toesmso when importinglibit works fine.Solution
Setting
sideEffects: ["*.css"]seems to solve the problem.This is an alternative solution to #55 and subset of #56.
Reference
https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free