This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
feat: integrate line chart with build query and update typings #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for superset-ui-plugins ready! Built with commit d69fcbf |
xtinec
reviewed
Apr 26, 2019
| @@ -83,10 +87,12 @@ export default class ChannelEncoder<Def extends ChannelDef<Output>, Output exten | |||
| return this.formatValue(this.get(datum)); | |||
| } | |||
|
|
|||
| get(datum: PlainObject, otherwise?: any) { | |||
| get<T extends ChannelInput>(datum: PlainObject, otherwise?: T) { | |||
xtinec
reviewed
Apr 26, 2019
| readonly formatValue: (value: any) => string; | ||
| protected readonly getValue: (datum: PlainObject) => ChannelInput; | ||
| readonly encodeValue: (value: ChannelInput) => Output | null | undefined; | ||
| readonly formatValue: (value: ChannelInput | { toString(): string }) => string; |
There was a problem hiding this comment.
hmm, what is the toString for?
There was a problem hiding this comment.
One of the formatter function's minimum requirement is something that can be converted into a string.
xtinec
approved these changes
Apr 26, 2019
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…e-superset#73) * feat: integrate line chart with buildQuery * fix: typings * fix: minor * feat: derive groupbys * fix: tooltip for single series
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
/api/v1/querybackendgroupbysfromencodingencodable