Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

feat: add box plot #78

Merged
merged 1 commit into from
May 7, 2019
Merged

feat: add box plot #78

merged 1 commit into from
May 7, 2019

Conversation

kristw
Copy link
Collaborator

@kristw kristw commented Apr 30, 2019

🏆 Enhancements

  • Add BoxPlotChartPlugin to preset-chart-xy, which has the encodeable-ish API, similar to line chart.
  • The new box plot supports horizontal mode.

image

image

@kristw kristw requested a review from a team as a code owner April 30, 2019 04:35
@ghost
Copy link

ghost commented Apr 30, 2019

There were the following issues with this Pull Request

  • Commit: 27b0b5a
    • ✖ body must have leading blank line

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@kristw kristw force-pushed the kristw--box-plot branch from 27b0b5a to 44d9423 Compare April 30, 2019 04:38
@ghost
Copy link

ghost commented Apr 30, 2019

There were the following issues with this Pull Request

  • Commit: 44d9423
    • ✖ body must have leading blank line

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@netlify
Copy link

netlify bot commented Apr 30, 2019

Deploy preview for superset-ui-plugins ready!

Built with commit 27b0b5a

https://deploy-preview-78--superset-ui-plugins.netlify.com

@netlify
Copy link

netlify bot commented Apr 30, 2019

Deploy preview for superset-ui-plugins ready!

Built with commit d42b5a7

https://deploy-preview-78--superset-ui-plugins.netlify.com

Squashed commits:
[23ad0d6] feat: working box plot
[a7ed565] fix: typings
[57a62b7] feat: clarify horizontal/vertical mode
[6312737] fix: typings
[2734de3] feat: box plot types
[cb3c239] fix: typings
[7e2dcda] feat: add box plot
@kristw kristw force-pushed the kristw--box-plot branch from 44d9423 to d42b5a7 Compare April 30, 2019 04:55
@kristw kristw added #enhancement New feature or request question Further information is requested reviewable and removed question Further information is requested labels May 4, 2019
@kristw kristw merged commit 72d4c30 into master May 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--box-plot branch May 7, 2019 18:50
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
* convert source to TS

* fix lint

* convert unit test to TS

* fix rebasing issue

* fix typings

* use ts-ignore
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
Squashed commits:
[23ad0d6] feat: working box plot
[a7ed565] fix: typings
[57a62b7] feat: clarify horizontal/vertical mode
[6312737] fix: typings
[2734de3] feat: box plot types
[cb3c239] fix: typings
[7e2dcda] feat: add box plot
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
#enhancement New feature or request reviewable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant