This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
feat(legacy-preset-chart-nvd3): show negative values on bars #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to combine changes from another PR as well. |
|
@kristw yeah, I branched this one off of that one. |
|
Do you want to complete that one first? This one can't be merged until that one goes in. |
kristw
changed the title
kristw
changed the title
|
Ah, sorry for getting the title wrong. I fixed the other one so it doesn't create a bunch of |
kristw
approved these changes
Mar 5, 2019
nytai
referenced
this pull request
in preset-io/superset-ui-plugins
Apr 27, 2020
nytai
referenced
this pull request
in preset-io/superset-ui-plugins
Apr 27, 2020
* fix(legacy-preset-chart-nvd3): redraw bar values after legend change * fix(legacy-preset-chart-nvd3): show labels on negative bars * fix(legacy-preset-chart-nvd3): fix lint * fix(legacy-preset-chart-nvd3): improve remove
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Turns out the functionality to show values in bars only works when they're positive. I modified the code so that it works with negative values as well:
This PR is based on #7.