This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
feat: update type for line chart series #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=======================================
Coverage 27.86% 27.86%
=======================================
Files 9 9
Lines 183 183
Branches 14 14
=======================================
Hits 51 51
Misses 128 128
Partials 4 4 Continue to review full report at Codecov.
|
Deploy preview for superset-ui-plugins ready! Built with commit 261f0d0 |
etr2460
approved these changes
Aug 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Yria
added a commit
to dooub/superset-ui-plugins
that referenced
this pull request
Oct 28, 2019
* commit '0916c62e98b7cf9f30212cb155a00748db29f043': (171 commits) v0.11.0 feat: upgrade @superset-ui to v0.12 (apache-superset#183) v0.10.46 fix(force to publish new version): force to publish new version v0.10.45 fix(fix issues in superset): fix issues in superset v0.10.44 fix: move react to table peerdependency (apache-superset#179) v0.10.43 docs: update thumbnails (apache-superset#178) v0.10.42 fix(fix types): fix types test(added more tests): added more tests fix(tablevis): update datatable change docs: update change log refactor(address code review comments): address code review comments v0.10.41 feat: update type for line chart series (apache-superset#175) build(bump the verions): bump the verions build(migrate to lunar 2*): migrate to lunar 2* ... # Conflicts: # packages/superset-ui-legacy-plugin-chart-pivot-table/package.json # packages/superset-ui-legacy-plugin-chart-table/package.json # packages/superset-ui-legacy-plugin-chart-table/src/Table.js # packages/superset-ui-legacy-preset-chart-nvd3/package.json # packages/superset-ui-preset-chart-xy/src/Line/Encoder.ts # packages/superset-ui-preset-chart-xy/src/encodeable/AbstractEncoder.ts
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…erset#175) * feat: add fallback component * feat: add superchart shell * feat: add vx/responsive type declaration * fix: path and dependencies * test: add unit tests * test: add more tests * docs: add storybook * test: fix FallBackComponent test * feat: make fallback accepts width and height * test: reach 100% * fix: test * fix: add more checks * refactor: rename SuperChartKernel to SuperChartCore * refactor: separate backward-compatibility code into another wrapper
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
* feat: update type for line chart series * fix: another place
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Update type