Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

feat: update type for line chart series #175

Merged
merged 2 commits into from
Aug 13, 2019
Merged

feat: update type for line chart series #175

merged 2 commits into from
Aug 13, 2019

Conversation

kristw
Copy link
Collaborator

@kristw kristw commented Aug 13, 2019

🏆 Enhancements

Update type

@kristw kristw requested a review from a team as a code owner August 13, 2019 21:59
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #175 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   27.86%   27.86%           
=======================================
  Files           9        9           
  Lines         183      183           
  Branches       14       14           
=======================================
  Hits           51       51           
  Misses        128      128           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8479099...261f0d0. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 13, 2019

Deploy preview for superset-ui-plugins ready!

Built with commit 261f0d0

https://deploy-preview-175--superset-ui-plugins.netlify.com

Copy link
Contributor

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kristw kristw merged commit c920d55 into master Aug 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--line-type branch August 13, 2019 22:43
Yria added a commit to dooub/superset-ui-plugins that referenced this pull request Oct 28, 2019
* commit '0916c62e98b7cf9f30212cb155a00748db29f043': (171 commits)
  v0.11.0
  feat: upgrade @superset-ui to v0.12 (apache-superset#183)
  v0.10.46
  fix(force to publish new version): force to publish new version
  v0.10.45
  fix(fix issues in superset): fix issues in superset
  v0.10.44
  fix: move react to table peerdependency (apache-superset#179)
  v0.10.43
  docs: update thumbnails (apache-superset#178)
  v0.10.42
  fix(fix types): fix types
  test(added more tests): added more tests
  fix(tablevis): update datatable change
  docs: update change log
  refactor(address code review comments): address code review comments
  v0.10.41
  feat: update type for line chart series (apache-superset#175)
  build(bump the verions): bump the verions
  build(migrate to lunar 2*): migrate to lunar 2*
  ...

# Conflicts:
#	packages/superset-ui-legacy-plugin-chart-pivot-table/package.json
#	packages/superset-ui-legacy-plugin-chart-table/package.json
#	packages/superset-ui-legacy-plugin-chart-table/src/Table.js
#	packages/superset-ui-legacy-preset-chart-nvd3/package.json
#	packages/superset-ui-preset-chart-xy/src/Line/Encoder.ts
#	packages/superset-ui-preset-chart-xy/src/encodeable/AbstractEncoder.ts
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
…erset#175)

* feat: add fallback component

* feat: add superchart shell

* feat: add vx/responsive type declaration

* fix: path and dependencies

* test: add unit tests

* test: add more tests

* docs: add storybook

* test: fix FallBackComponent test

* feat: make fallback accepts width and height

* test: reach 100%

* fix: test

* fix: add more checks

* refactor: rename SuperChartKernel to SuperChartCore

* refactor: separate backward-compatibility code into another wrapper
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
* feat: update type for line chart series

* fix: another place
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants