-
Notifications
You must be signed in to change notification settings - Fork 271
Update readme and remove unnecessary items from package.json #17
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 89 89
=====================================
Hits 89 89 Continue to review full report at Codecov.
|
"jed": "^1.1.1" | ||
}, | ||
"beemo": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why didn't I remove these?! thanks.
|
||
```sh | ||
git clone ...superset-ui && cd superset-ui | ||
npm install | ||
lerna bootstrap | ||
npm run bootstrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is okay but yarn
is a root dep
, and most of the scripts are run with yarn run ...
.
This might not be as important locally / in the docs, but this seems to be important for the travis
build right now. learna bootstrap
fails when run in the travis env which I found last week. it seems like travis
uses it's own flavor of npm
which gets called if you call lerna bootstrap
, and it fails the build without a lock
file, which we don't have or want. I enabled yarn
workspaces for the build-config, and they actually also can do between-package sym linking like lerna bootstrap
, so it does what we want.
With the new SIP for moving away from npm
we might have to re-think this, but wanted to give more context as to why yarn
is around. I'll leave it to you if you want to use npm
or yarn
here, like I said for docs it probably doesn't matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks for the context. My intention was that I was gonna npm install -g lerna
and then saw it as devDependencies
here so I added the bootstrap
script so I can use the local lerna
, plus I just create the generator-superset and want to call lerna bootstrap
at the end of scaffolding. It is possible that user may not have global lerna
so calling the local version is more sure.
I usually use npm run xxx
and yarn xxx
interchangeably. The yarn
workspace thing sounds interesting though. It would be great to either use that or lerna
, just not both.
* fix: 🐛 y axis bounds * fix: clip edge only when necessary * docs: update storybook * fix: remove src ref from storybook * fix: import order
npm run bootstrap
to calllerna bootstrap
package.json
intranslation
@williaster