Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Add @superset-ui/chart with extract modules and additional unit tests #23

Merged
merged 5 commits into from
Nov 6, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Nov 6, 2018

🏆 Enhancements

  • Migrate Chart registries and data structures from incubator-superset.
  • No new features. Only add unit tests to ensure 100% code coverage!

Note: Haven't moved SuperChart here yet. Will do that in a separate review.

@kristw kristw changed the title Kristw chart Add @superset-ui/chart with extract modules and additional unit tests Nov 6, 2018
@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #23   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          30     37    +7     
  Lines         260    322   +62     
=====================================
+ Hits          260    322   +62
Impacted Files Coverage Δ
.../src/registries/ChartComponentRegistrySingleton.js 100% <100%> (ø)
...t/src/registries/ChartMetadataRegistrySingleton.js 100% <100%> (ø)
...src/registries/ChartBuildQueryRegistrySingleton.js 100% <100%> (ø)
...registries/ChartTransformPropsRegistrySingleton.js 100% <100%> (ø)
...ages/superset-ui-chart/src/models/ChartMetadata.js 100% <100%> (ø)
...ackages/superset-ui-chart/src/models/ChartProps.js 100% <100%> (ø)
...ckages/superset-ui-chart/src/models/ChartPlugin.js 100% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28bcd47...dfedee0. Read the comment docs.

@kristw kristw added the reviewable Ready for review label Nov 6, 2018
@mistercrunch
Copy link
Contributor

LGTM 💯

@kristw kristw self-assigned this Nov 6, 2018
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥🔥🔥

@kristw kristw merged commit e942712 into master Nov 6, 2018
@kristw kristw deleted the kristw-chart branch November 6, 2018 22:45
@kristw kristw added this to the v0.5.0 milestone Nov 13, 2018
@kristw kristw added reviewable Ready for review and removed reviewable Ready for review labels Nov 13, 2018
@kristw kristw added the #enhancement New feature or request label Dec 6, 2018
kristw added a commit that referenced this pull request Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
#enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants