Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(preset-chart-nvd3): migration from plugins repo #399

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Apr 28, 2020

🏠 Internal

Migrate code and also update storybook to work with the new settings.

@kristw kristw requested a review from a team as a code owner April 28, 2020 19:40
@vercel
Copy link

vercel bot commented Apr 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/kz1ve2go1
✅ Preview: https://superset-ui-git-kristw-nvd3.superset.now.sh

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #399 into master will decrease coverage by 2.38%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   24.63%   22.25%   -2.39%     
==========================================
  Files         239      261      +22     
  Lines        5747     6474     +727     
  Branches      581      587       +6     
==========================================
+ Hits         1416     1441      +25     
- Misses       4294     4996     +702     
  Partials       37       37              
Impacted Files Coverage Δ
plugins/legacy-preset-chart-nvd3/src/Area/index.js 0.00% <ø> (ø)
plugins/legacy-preset-chart-nvd3/src/Bar/index.js 0.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/BoxPlot/index.js 0.00% <ø> (ø)
...ugins/legacy-preset-chart-nvd3/src/Bubble/index.js 0.00% <ø> (ø)
...ugins/legacy-preset-chart-nvd3/src/Bullet/index.js 0.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/Compare/index.js 0.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/DistBar/index.js 0.00% <ø> (ø)
...ins/legacy-preset-chart-nvd3/src/DualLine/index.js 0.00% <ø> (ø)
plugins/legacy-preset-chart-nvd3/src/Line/index.js 0.00% <ø> (ø)
...gacy-preset-chart-nvd3/src/LineMulti/LineMulti.jsx 0.00% <ø> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 672e02d...25d8370. Read the comment docs.

Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I like how stories for each chart type are now properly grouped.

@ktmud ktmud merged commit dbd84f2 into master Apr 28, 2020
@ktmud ktmud deleted the kristw--nvd3 branch April 28, 2020 22:43
@kristw
Copy link
Contributor Author

kristw commented Apr 28, 2020

@ktmud just curious what was merged and pushed to the branch?

@ktmud
Copy link
Contributor

ktmud commented Apr 28, 2020

@kristw I just used GitHub's "Update branch" button. I guess it's just any change that has been merged to master after you started working on this branch.

suddjian pushed a commit to suddjian/superset-ui that referenced this pull request Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants