Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(legacy-preset-big-number): use emotion styling #455

Merged
merged 19 commits into from
May 21, 2020

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented May 8, 2020

💔 Breaking Changes

🏆 Enhancements
Adding emotion styling, pulling from Superset theme, particularly for typographic purposes in Big Number plugin. This also removes the CSS file, and puts ALL the styling INSIDE the component where it's exported. Emotion includes SASS out of the box, so I've condensed things a bit accordingly.

This also adds a ThemeProvider to the storybook, so the plugins work/look right there.

Before screenshots:
Screen Shot 2020-05-20 at 3 11 46 PM
Screen Shot 2020-05-20 at 3 11 56 PM

After screenshots:
Screen Shot 2020-05-20 at 3 09 13 PM
Screen Shot 2020-05-20 at 3 12 17 PM

📜 Documentation

🐛 Bug Fix

🏠 Internal

@vercel
Copy link

vercel bot commented May 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/1lha6vut3
✅ Preview: https://superset-ui-git-fork-preset-io-big-number-typography.superset.now.sh

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #455 into master will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   22.72%   22.62%   -0.11%     
==========================================
  Files         276      281       +5     
  Lines        6670     6696      +26     
  Branches      644      648       +4     
==========================================
- Hits         1516     1515       -1     
- Misses       5115     5142      +27     
  Partials       39       39              
Impacted Files Coverage Δ
...reset-chart-big-number/src/BigNumber/BigNumber.tsx 0.00% <0.00%> (ø)
plugins/legacy-plugin-chart-table/src/index.ts 0.00% <0.00%> (ø)
plugins/legacy-plugin-chart-iframe/src/index.js 0.00% <0.00%> (ø)
plugins/legacy-plugin-chart-heatmap/src/index.js 0.00% <0.00%> (ø)
plugins/legacy-plugin-chart-horizon/src/index.js 0.00% <0.00%> (ø)
plugins/legacy-plugin-chart-map-box/src/index.js 0.00% <0.00%> (ø)
packages/superset-ui-query/src/buildQueryObject.ts 100.00% <0.00%> (ø)
plugins/legacy-plugin-chart-histogram/src/index.js 0.00% <0.00%> (ø)
...kages/superset-ui-query/src/types/QueryFormData.ts 100.00% <0.00%> (ø)
...ns/legacy-plugin-chart-force-directed/src/index.js 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b42bc1...3625735. Read the comment docs.

@rusackas rusackas force-pushed the big-number-typography branch from e6ec2cf to 57283f1 Compare May 8, 2020 05:03
@kristw kristw changed the title Big number typography feat(legacy-preset-big-number): use emotion styling May 8, 2020
@rusackas rusackas marked this pull request as ready for review May 20, 2020 22:54
@rusackas rusackas requested a review from a team as a code owner May 20, 2020 22:54
@rusackas rusackas requested review from suddjian, etr2460, ktmud and kristw May 20, 2020 22:59
Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noted that the font family for big number is not the same as the default font. LGTM if this is intentional.

Copy link
Contributor

@kristw kristw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Same question with @ktmud

@rusackas
Copy link
Member Author

Font change is intentional, bringing it inline with the rest of Incubator-Superset's UI. Other viz pugins will follow suit, changing the fonts for axes, tooltips, whatever. Eventually we'll do the same for colors, border radii, and all the other little bits and baubles that come from the theme. This will be a long tail, but this PR show the pattern.

@rusackas rusackas merged commit 46eb663 into apache-superset:master May 21, 2020
@rusackas rusackas deleted the big-number-typography branch May 21, 2020 00:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants