-
Notifications
You must be signed in to change notification settings - Fork 271
feat(legacy-preset-big-number): use emotion styling #455
feat(legacy-preset-big-number): use emotion styling #455
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/1lha6vut3 |
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
- Coverage 22.72% 22.62% -0.11%
==========================================
Files 276 281 +5
Lines 6670 6696 +26
Branches 644 648 +4
==========================================
- Hits 1516 1515 -1
- Misses 5115 5142 +27
Partials 39 39
Continue to review full report at Codecov.
|
e6ec2cf
to
57283f1
Compare
57283f1
to
631c7ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noted that the font family for big number is not the same as the default font. LGTM if this is intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Same question with @ktmud
Font change is intentional, bringing it inline with the rest of Incubator-Superset's UI. Other viz pugins will follow suit, changing the fonts for axes, tooltips, whatever. Eventually we'll do the same for colors, border radii, and all the other little bits and baubles that come from the theme. This will be a long tail, but this PR show the pattern. |
💔 Breaking Changes
🏆 Enhancements
Adding emotion styling, pulling from Superset theme, particularly for typographic purposes in Big Number plugin. This also removes the CSS file, and puts ALL the styling INSIDE the component where it's exported. Emotion includes SASS out of the box, so I've condensed things a bit accordingly.
This also adds a ThemeProvider to the storybook, so the plugins work/look right there.
Before screenshots:
After screenshots:
📜 Documentation
🐛 Bug Fix
🏠 Internal