Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(legacy-plugin-chart-nvd3): disable bad linting rule #488

Merged
merged 2 commits into from
May 13, 2020

Conversation

suddjian
Copy link
Member

🐛 Bug Fix

The import/extensions rule makes it impossible to correctly import ts from js.

@suddjian suddjian requested a review from a team as a code owner May 13, 2020 19:15
@vercel
Copy link

vercel bot commented May 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/91tbmianm
✅ Preview: https://superset-ui-git-fork-suddjian-fix-nvd3-typescript.superset.now.sh

@vercel vercel bot temporarily deployed to Preview May 13, 2020 19:15 Inactive
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #488 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   22.74%   22.74%           
=======================================
  Files         276      276           
  Lines        6671     6671           
  Branches      644      644           
=======================================
  Hits         1517     1517           
  Misses       5114     5114           
  Partials       40       40           
Impacted Files Coverage Δ
plugins/legacy-plugin-chart-sunburst/src/index.js 0.00% <ø> (ø)
plugins/legacy-preset-chart-nvd3/src/Area/index.js 0.00% <ø> (ø)
plugins/legacy-preset-chart-nvd3/src/Bar/index.js 0.00% <ø> (ø)
...ugins/legacy-preset-chart-nvd3/src/Bubble/index.js 0.00% <ø> (ø)
...ugins/legacy-preset-chart-nvd3/src/Bullet/index.js 0.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/Compare/index.js 0.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/DistBar/index.js 0.00% <ø> (ø)
...ins/legacy-preset-chart-nvd3/src/DualLine/index.js 0.00% <ø> (ø)
plugins/legacy-preset-chart-nvd3/src/Line/index.js 0.00% <ø> (ø)
...ns/legacy-preset-chart-nvd3/src/LineMulti/index.js 0.00% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce76aca...dbd6bc2. Read the comment docs.

@suddjian
Copy link
Member Author

It's approved, tests pass, but codecov is confused. Merging!

@suddjian suddjian merged commit 9b6d611 into apache-superset:master May 13, 2020
@suddjian suddjian deleted the fix-nvd3-typescript branch May 13, 2020 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants