Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: nvd3 annotation tooltip #540

Merged
merged 1 commit into from
May 26, 2020
Merged

Conversation

etr2460
Copy link
Contributor

@etr2460 etr2460 commented May 26, 2020

🐛 Bug Fix

It looks like a long time ago, the sourceType field for annotations was migrated from being table to NATIVE. This broke the tooltip for annotations. Since I'm quite unfamiliar with this code, and for backwards compatibility, I've left the old selector in but also added the new one which should resolve the issue.

New class name in superset:
image

to: @ktmud @graceguo-supercat @kristw

@etr2460 etr2460 requested a review from a team as a code owner May 26, 2020 19:52
@vercel
Copy link

vercel bot commented May 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/og6a847ea
✅ Preview: https://superset-ui-git-erik-ritter-fix-nvd3-annotations.superset.now.sh

@etr2460 etr2460 changed the title fix: nvd3 annotations fix: nvd3 annotation tooltip May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   23.21%   23.21%           
=======================================
  Files         291      291           
  Lines        6790     6790           
  Branches      675      675           
=======================================
  Hits         1576     1576           
  Misses       5176     5176           
  Partials       38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79579d2...6660596. Read the comment docs.

@etr2460
Copy link
Contributor Author

etr2460 commented May 26, 2020

After researching a bit more, it seems like the old class is still applied for annotation events built from a table as opposed to an annotation layer. Therefore, we need both classes here for the styles to apply properly

@etr2460 etr2460 merged commit 6ea134d into master May 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the erik-ritter--fix-nvd3-annotations branch May 26, 2020 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants