This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat(superset-ui-style): export ThemeProvider and useTheme #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/78vtky9xs |
ktmud
force-pushed
the
export-themeprovider
branch
from
62829aa to
89514c7
Compare
ktmud
force-pushed
the
export-themeprovider
branch
from
89514c7 to
44be3bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
==========================================
+ Coverage 23.13% 23.14% +0.01%
==========================================
Files 290 290
Lines 6783 6784 +1
Branches 676 676
==========================================
+ Hits 1569 1570 +1
Misses 5176 5176
Partials 38 38
Continue to review full report at Codecov.
|
Export ThemeProvider, useTheme, and withTheme from emotion-theming since they are almost always used together with supersetTheme. This makes importing and package dependencies simpler.
ktmud
force-pushed
the
export-themeprovider
branch
from
44be3bd to
7e49284
Compare
kristw
approved these changes
Jun 1, 2020
kristw
approved these changes
Jun 1, 2020
Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export
ThemeProvider,useThemeandwithThemefromemotion-themingin@superset-ui/style, since they are almost always used together withsupersetTheme.This makes importing and package dependencies in Superset app (and dependent plugins) a little easier.
🏆 Enhancements