Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Jest/TS config adjustments (allow for debugging tests in WebStorm) #77

Closed
wants to merge 1 commit into from

Conversation

soboko
Copy link
Contributor

@soboko soboko commented Jan 12, 2019

🏆 Enhancements 🏠 Internal

These changes are necessary (AFAIK) for setting up a Jest configuration in WebStorm that allows for setting breakpoints while running tests. Tests still work the same from the command line.

Such a config looks like this for one test file:

image

...and for all tests:

image

to: @conglei @kristw @williaster

@soboko soboko requested a review from a team as a code owner January 12, 2019 01:54
@codecov
Copy link

codecov bot commented Jan 12, 2019

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #77   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          67     67           
  Lines         744    744           
  Branches      130    130           
=====================================
  Hits          744    744

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b40189c...31d0c07. Read the comment docs.

@soboko soboko changed the title [WIP] Config adjustments for debugging tests in WebStorm Jest/TS config adjustments (allow for debugging tests in WebStorm) Jan 12, 2019
@williaster
Copy link
Contributor

Hey @soboko thanks for looking into this. All of our lib configuration lives in @data-ui/build-config so updates should go there.

That said -- the intention with build-config is to be replaced entirely with an airbnb open-source build config that has exact parity (sometime in Q1), so I’d like to not deviate far from that one (which does not use ts-jest). So I'm not sure about the best way around it, internally they would recommend using vs code, but you can ask in our internal #typescript channel to see if it's possible to set this up in Webstorm without ts-jest. Is there a reason you need to step through in an IDE vs the browser source view?

@soboko
Copy link
Contributor Author

soboko commented Jan 16, 2019

Hey @soboko thanks for looking into this. All of our lib configuration lives in @data-ui/build-config so updates should go there.

That said -- the intention with build-config is to be replaced entirely with an airbnb open-source build config that has exact parity (sometime in Q1), so I’d like to not deviate far from that one (which does not use ts-jest). So I'm not sure about the best way around it, internally they would recommend using vs code, but you can ask in our internal #typescript channel to see if it's possible to set this up in Webstorm without ts-jest.

Hmm, I can always keep this stashed locally and apply it as needed, not a huge deal.

Is there a reason you need to step through in an IDE vs the browser source view?

Mainly for running tests.

@kristw kristw added the abandoned No longer intend to address issue or finish PR label Feb 5, 2019
@kristw kristw closed this Feb 5, 2019
kristw pushed a commit that referenced this pull request Apr 17, 2020
* feat(chart): add basic working look sankey chart

* fix(doc): update readme and remove dead code

* fix(clean): clean up both style and code

* fix(reorg): reogranize for clarity

* fix(path): remove dev path to chart

* fix(lint): remove lint

* fix(pr): fixes for PR

* fix(path): fix dev path

* fix(lint): remove unused
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
abandoned No longer intend to address issue or finish PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants