ARTEMIS-5141 Add or remove plugins on configuration reload #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusdev
reviewed
Nov 11, 2024
...tion-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/RedeployTest.java
Show resolved
Hide resolved
AntonRoskvist
force-pushed
the
hotDeployPlugins
branch
from
3a9ae21
to
454107f
Compare
That is not intentional, thanks for catching that @brusdev |
brusdev
reviewed
Nov 22, 2024
There was a problem hiding this comment.
The existing broker plugins in the config are unregistered and registered each time the the config is reloaded. This could be a breaking change because the current version only load broker plugins at startup.
You can check this behavior adding the same plugin to both reload-plugin.xml and reload-plugin-updated.xml files, i.e. brusdev@3115925
|
Yes I see it, I'll have to take a closer look at this. Thanks @brusdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.