Implementation of WebDAV Adapter for Nextcloud Integration #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karankotz
changed the title
karankotz
changed the title
karankotz
changed the title
|
Looks good but the registry changes should be in the registry-refactoring module instead of registry-core. |
|
@machristie There is no registry-refactoring module, this branch was built from the staging branch, do you have any suggestions to achieve this? |
|
If this branch were based on develop then it would have the registry-refactoring module. Is there a reason it is based on staging? |
|
@machristie As discussed these changes will currently stay on this branch and will need be merged later with the registry-refactoring module of the develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for the addition of the WebDAV adapter in the apache airavata to support the integration of the nextcloud. The first part changes are made to support the data movement to the nextcloud via WebDAV adapter in the airavata api-orchestrator.
The following changes are made -
Addition of the new data movement protocol in data_movement_model of the resource_catalog_models.
Implemented new data movement model WebDAVDataMovement in the airavata-data-models
Added the following methods to the airavata-api and registry-api (specifically in airavataserverhandler and registryserverhandler)
--addWebDAVDataMovementDetails(..)
--updateWebDAVDataMovementDetails(..)
--getWebDAVDataMovement(..)
Implemented the following methods for the ComputeResource interface.
--addWebDAVDataMovementDetails(..)
--getWebDAVDataMovement(..)
Made changes in the AppCatalogJPAUtils, AppCatalogResourceType, AppCatalogThriftConversion to support the WebDAV adapter in the airavata-registry-core.
Added the WebDavDataMovementResource in the app catalog resources of airavata-registry-core.
Added the WebDavDataMovement model in the app catalog model of the airavata-registry-core.
Created the sample test case addWebDavStorageResourceTest() in the StorageResourceAppCatalogTest class of the airavata-registry-core.
The further changes are yet to be updated in the helix module with the WebDAV adapter (Added in the commit f15dfc2).
The helix module has been added with the WebDAV adaptor.
The WebDAV adaptor is used to connect to the nextcloud instance and upload the output files
generated by the compute resource to the nextcloud server.