Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent templated field logic checks in __init__ of operators automatically #29069

Closed
1 task done
potiuk opened this issue Jan 20, 2023 · 4 comments · Fixed by #33786
Closed
1 task done

Prevent templated field logic checks in __init__ of operators automatically #29069

potiuk opened this issue Jan 20, 2023 · 4 comments · Fixed by #33786
Assignees
Labels
kind:meta High-level information important to the community

Comments

@potiuk
Copy link
Member

potiuk commented Jan 20, 2023

Body

It happens all-too-often that in our operators we have some initialization logic that checks the content of templated fields or generally parameters passed to the operators. This however has an adverse effect that if those checks assume some content or type of those fields, there are a number of cases that those checks are wrong.

Example here: #27328

We should have a way to automatically check if someone is performing such logical checks in all our operators.

This has been initially discussed here: #27328 (comment) and there are some ideas how this might be done.

However we are open for any way of doing it

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@shahar1
Copy link
Contributor

shahar1 commented May 16, 2023

@eladkal Please assign me

@potiuk
Copy link
Member Author

potiuk commented May 16, 2023

Done

@ephraimbuddy
Copy link
Contributor

@shahar1, are you still working on this?

@shahar1
Copy link
Contributor

shahar1 commented Jul 4, 2023

@shahar1, are you still working on this?

I started working on it a while ago, I paused due to some personal circumstances.
I'll try to get back to it in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants