Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml [project] section without name and version attributes is not pep 621 compliant #33854

Closed
1 of 2 tasks
risicle opened this issue Aug 28, 2023 · 4 comments · Fixed by #34014
Closed
1 of 2 tasks
Labels
good first issue kind:bug This is a clearly a bug kind:meta High-level information important to the community

Comments

@risicle
Copy link

risicle commented Aug 28, 2023

Apache Airflow version

2.7.0

What happened

https://peps.python.org/pep-0621/

[project]

Newer setuptools will complain and fail to install. When building the NixOS package for 2.7.0 we now get:

ValueError: invalid pyproject.toml config: `project`.
configuration error: `project` must contain ['name'] properties

What you think should happen instead

No response

How to reproduce

Operating System

All

Versions of Apache Airflow Providers

No response

Deployment

Other

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@risicle risicle added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Aug 28, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 28, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@risicle risicle changed the title pyproject.toml [project] section without a name attribute is not pep 621 compliant pyproject.toml [project] section without name and version attributes is not pep 621 compliant Aug 28, 2023
@potiuk
Copy link
Member

potiuk commented Aug 29, 2023

How about fixing it ? Woudl you like to contribute fix? seems you know exactly what to fix and you need it - seems no brainer @risicle ?

@risicle
Copy link
Author

risicle commented Aug 29, 2023

It might not be quite such a no-brainer if you want to single-source the version.

@potiuk
Copy link
Member

potiuk commented Aug 30, 2023

It's easy - you can synchronize the version with pre-commit. We are already doing it in a few places.

https://github.com/apache/airflow/blob/main/scripts/ci/pre_commit/pre_commit_update_versions.py

We are not going to change to a single version source being pyproject.toml - but the pre-commit will take care about synchronizing it from the "source of truth" being airflow.__version__ in airflow/__init__.py.

@eladkal eladkal added good first issue kind:meta High-level information important to the community and removed area:core needs-triage label for new issues that we didn't triage yet labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue kind:bug This is a clearly a bug kind:meta High-level information important to the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants