Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Flask-sesssion 0.6.0+ #36897

Open
1 task done
potiuk opened this issue Jan 19, 2024 · 9 comments
Open
1 task done

Support for Flask-sesssion 0.6.0+ #36897

potiuk opened this issue Jan 19, 2024 · 9 comments
Labels
kind:meta High-level information important to the community
Milestone

Comments

@potiuk
Copy link
Member

potiuk commented Jan 19, 2024

Body

New version of Flask-Session breaks our AirflowDatabaseSessionInterface by add new arguments into the constructor sid_length, sequence, schema and bind_key and make all arguments are mandatory include previously optional use_signer and permanent

We limited flask-session to < 0.6.0 for now in #36895 , but we need to update our code to fix it.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@potiuk potiuk added the kind:meta High-level information important to the community label Jan 19, 2024
@potiuk potiuk added this to the Airflow 2.8.2 milestone Jan 19, 2024
@Taragolis
Copy link
Contributor

Yeah also better to wait until changelogs for 0.6 published:

Maybe other breaking changes was introduced in this release

@potiuk
Copy link
Member Author

potiuk commented Jan 21, 2024

Asked pallets-eco/flask-session#210

@potiuk
Copy link
Member Author

potiuk commented Feb 10, 2024

0.6.0rc1 released notes are published

@potiuk
Copy link
Member Author

potiuk commented Feb 27, 2024

Not sure if we will get it .. rc notes published 2 weeks ago, and the author does not realise that once you released 0.6.0 you cannot just delete it from PyPI (even if I explained it to the author). I don't have high hopes here.

@Taragolis
Copy link
Contributor

I tried to figure out how to adopt the changes, rc0 or released version, but have no a clue right now.

@Lxstr
Copy link

Lxstr commented Mar 4, 2024

Hi folks. I've tried to get flask-session up to date, some of the issues are quite deep and longstanding. I'm not the original author but no one else has wanted to maintain it. I'm also working within pallets and don't have full pypi access or readthedocs access so I am doing my best with what access I have. I've got 0.7.0rc1 available with a fully overhauled docs at https://flask-session--212.org.readthedocs.build/en/212/. Will appreciate any assistance with the elements that airflow uses.

@potiuk
Copy link
Member Author

potiuk commented Mar 10, 2024

Hey @Taragolis -> will you be taking a look at that :) ? Seems that you were the closest to get it working

@Taragolis
Copy link
Contributor

Yeah, I will have a look today or tomorrow.

@Lxstr
Copy link

Lxstr commented Mar 12, 2024

0.7.0rc2 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants