Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-84 Migrate public endpoints from api_connexion to the new Rest API #42370

Closed
1 task done
pierrejeambrun opened this issue Sep 20, 2024 · 33 comments
Closed
1 task done

AIP-84 Migrate public endpoints from api_connexion to the new Rest API #42370

pierrejeambrun opened this issue Sep 20, 2024 · 33 comments
Assignees
@bbovenzi @pierrejeambrun
Labels
AIP-84 Modern Rest API area:API Airflow's REST/HTTP API kind:meta High-level information important to the community

Comments

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Sep 20, 2024 •
edited
Loading

Body

#42366 is taking care of migrating private endpoints.

This issue focuses on migrating all the public ones. Ideally they shouldn't change too much and be feature rich compare to airflow 2.x.

An exemple PR can be found here #42196

Tasks (total ~ 81 endpoints)

Backfill (6 endpoints) @dstandish

Config (2 endpoints) @rawwar

Connection @bugraoz93 (6 endpoints)

DAG (5 endpoints)

Dag Parsing (1 endpoint)

Dag Runs @rawwar (9 endpoints)

Dag Source (1 endpoint)

Dag Stats (1 endpoint)

Dag Warnings (1 endpoint) @rawwar

Dataset / Assets (10 endpoints) @amoghrajesh

Event Logs (2 endpoints)

Extra Link (1 endpoint)

Monitor (2 endpoints)

Import Error (2 endpoints) @jason810496

Log (1 endpoint)

Plugin (1 endpoint)

Pool (5 endpoints) @pierrejeambrun

Provider (1 endpoint)

Task (2 endpoints) @omkar-foss

Task Instance (15 endpoints) @pierrejeambrun

Variables (5 endpoints)

XCom (2 endpoints)

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@pierrejeambrun pierrejeambrun added the kind:meta High-level information important to the community label Sep 20, 2024
@pierrejeambrun pierrejeambrun mentioned this issue Sep 20, 2024
Closed
2 tasks
@dosubot dosubot bot added the area:API Airflow's REST/HTTP API label Sep 20, 2024
@pierrejeambrun pierrejeambrun added the AIP-84 Modern Rest API label Sep 20, 2024
@omkar-foss
Copy link
Collaborator

Trimming down views.py is very tempting 😄

May I pick this up? If yes, please assign this issue to me. Thanks!

@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Sep 23, 2024 •
edited
Loading

Hello @omkar-foss,

views.py are mostly 'rendered' front end that will get replaced by the new UI react, in views.py you also find private/UI REST route, most of them are with the /object/ prefix, such as def grid_data. If you want to work on those UI dedicated endpoints you can that would be part of #42366.

This issue focuses on the public endpoints, those are located under the api_connexion folder.

In anycase, just mention the endpoint you are working on, so people do not do the same ones, and I will update the description to track that :). I think we should do one at the time.

@omkar-foss
Copy link
Collaborator

Hi @pierrejeambrun, thank you for explaining it to me, much appreciate it.

I'll start migrating the public endpoints, beginning with migration of the DAG Details API (get_dag_details) in api_connexion/endpoints/dag_endpoint.py.

Since this is a meta issue (missed that previously!), I'll create the issue/PR corresponding to the endpoint(s) that I'll be working on and link to this issue (like usual).

P.S: views.py will have to wait :)

@omkar-foss omkar-foss mentioned this issue Sep 24, 2024
Closed
2 tasks
@pierrejeambrun pierrejeambrun mentioned this issue Sep 25, 2024
Open
3 tasks
This was referenced Sep 25, 2024
Closed
Closed
@bugraoz93
Copy link
Collaborator

Thanks for creating the ticket @pierrejeambrun! Let me take connection endpoints

@bugraoz93 bugraoz93 mentioned this issue Sep 28, 2024
Closed
2 tasks
@pierrejeambrun
Copy link
Member Author

Great, thanks @bugraoz93

This was referenced Sep 30, 2024
Closed
Closed
Closed
Closed
Closed
@bugraoz93
Copy link
Collaborator

bugraoz93 commented Sep 30, 2024 •
edited
Loading

Thanks for assigning! Let me save you from regular updates :) I created issues for all the endpoints in connections.

@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Oct 1, 2024 •
edited
Loading

Great, thanks @bugraoz93. I just updated the meta issue with those new additions. Let me know if you plan to work on all of them so I can assign you, or just some of them so I can label the others with good first issue and let other contributors grab them :)

@bugraoz93
Copy link
Collaborator

I am planning to work on all of them @pierrejeambrun. if you can assign them to me, that would be great! Thanks :)

This was referenced Oct 1, 2024
Merged
Closed
Closed
@omkar-foss
Copy link
Collaborator

Hey folks! After #42631 (open for review), I can pick up these two next in order:

  1. get_dag - AIP-84 Migrate the public endpoint Get DAG to FastAPI #42652
  2. delete_dag - AIP-84 Migrate the public endpoint Delete DAG to FastAPI #42650

With these 2 done, I suppose we should have the dags.py migration complete. When you find some time, please update this meta and assign these to me, thank you! 😃

@bbovenzi
Copy link
Contributor

bbovenzi commented Oct 2, 2024

@omkar-foss Assigned. Thanks for picking these issues up!

@omkar-foss omkar-foss mentioned this issue Nov 13, 2024
Merged
@amoghrajesh amoghrajesh mentioned this issue Nov 14, 2024
Closed
@vatsrahul1001 vatsrahul1001 mentioned this issue Nov 15, 2024
Closed
@pierrejeambrun pierrejeambrun mentioned this issue Nov 15, 2024
Merged
@vatsrahul1001 vatsrahul1001 mentioned this issue Nov 15, 2024
Closed
This was referenced Nov 15, 2024
Closed
Merged
Merged
Merged
Merged
This was referenced Nov 18, 2024
Merged
Merged
@kandharvishnu kandharvishnu mentioned this issue Nov 20, 2024
Merged
@rawwar rawwar mentioned this issue Nov 20, 2024
Merged
This was referenced Nov 20, 2024
Merged
Merged
@bbovenzi
Copy link
Contributor

@prabhusneha I see you're assigned to Logs. What is the status of getting the logs for a task instance? That would be a useful one to get in the UI soon!

@rawwar rawwar mentioned this issue Nov 21, 2024
Closed
2 tasks
@utkarsharma2
Copy link
Contributor

@prabhusneha I see you're assigned to Logs. What is the status of getting the logs for a task instance? That would be a useful one to get in the UI soon!

Hey, @bbovenzi I'm taking care of task instance logs endpoint, I'm mostly done with it, but there are a couple of test cases that require setting users in fastapi which requires a little more work. I'll keep you posted.

@phanikumv
Copy link
Contributor

Thanks @utkarsharma2 (updated the description accordingly).

@utkarsharma2 utkarsharma2 mentioned this issue Nov 21, 2024
Merged
@omkar-foss omkar-foss mentioned this issue Nov 21, 2024
Closed
@prabhusneha prabhusneha mentioned this issue Nov 22, 2024
Merged
This was referenced Nov 23, 2024
Merged
Merged
@prabhusneha prabhusneha mentioned this issue Nov 27, 2024
Merged
@pierrejeambrun
Copy link
Member Author

Thanks a lot to everyone that contributed, closing a big one 🎉

@github-project-automation github-project-automation bot moved this from In Progress to Done in AIP-84 MODERN REST API Nov 28, 2024
@pierrejeambrun pierrejeambrun changed the title AIP-84 Migrate public endpoints from api_connexion to the new rest api AIP-84 Migrate public endpoints from api_connexion to the new Rest API Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbovenzi bbovenzi

@pierrejeambrun pierrejeambrun

Labels
AIP-84 Modern Rest API area:API Airflow's REST/HTTP API kind:meta High-level information important to the community
Projects
AIP-84 MODERN REST API
Status: Done
Milestone
No milestone
Development

No branches or pull requests
10 participants
@potiuk @bbovenzi @bugraoz93 @utkarsharma2 @pierrejeambrun @rawwar @omkar-foss @jason810496 @michaeljs-c @phanikumv