Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach roles to AD groups - Azure OAuth #9583

Closed
sk2991 opened this issue Jun 30, 2020 · 8 comments
Closed

Attach roles to AD groups - Azure OAuth #9583

sk2991 opened this issue Jun 30, 2020 · 8 comments
Labels
area:auth kind:bug This is a clearly a bug

Comments

@sk2991
Copy link

sk2991 commented Jun 30, 2020

We have implemented RBAC using Azure OAuth, Is there any way to attach a role to AD group - so that users part of that AD groups/Tenant can get default access to the attached role

Apache Airflow version: 1.10.10

Kubernetes version (if you are using kubernetes) (use kubectl version): 1.15.10

Environment:

  • Cloud provider or hardware configuration: Azure (AKS)
  • OS (e.g. from /etc/os-release): Debian GNU/Linux
  • Kernel (e.g. uname -a): 4.15.0-1089-azure
  • Install tools:
  • Others:

What happened:

What you expected to happen:

attach a role to AD group (or) Azure tenant

How to reproduce it:

Helm install stable/airflow
Implement RBAC using Azure OAuth

@sk2991 sk2991 added the kind:bug This is a clearly a bug label Jun 30, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 30, 2020

Thanks for opening your first issue here! Be sure to follow the issue template!

@elwinarens
Copy link

@sk2991 Would you mind sharing your Azure OAuth implementation?

@rafaelpierre
Copy link

@sk2991 +1

@sk2991 Would you mind sharing your Azure OAuth implementation?

@mik-laj
Copy link
Member

mik-laj commented Jul 3, 2020

Is this helpful for you? I don't use Azure OAuth, so I'm not sure this change applies here.
dpgaspar/Flask-AppBuilder#1410

@sk2991
Copy link
Author

sk2991 commented Jul 5, 2020

@elwinarens @rafaelpierre - I have used this link to configure Azure OAuth.
Other useful links:
#3015
https://flask-appbuilder.readthedocs.io/en/latest/security.html#authentication-oauth

@sk2991
Copy link
Author

sk2991 commented Jul 5, 2020

@mik-laj It does help to some extent. Is there anyway to extend this? Instead of declaring "AUTH_USER_REGISTRATION_ROLE_JMESPATH = "contains(['alice@example.com', 'celine@example.com'], email) && 'Admin' || 'Public'"" this manually in config file - can we assign it dynamically?

@hussainsaify
Copy link

@sk2991 were you able to solve this using a more cleaner method than shared above?

@sk2991
Copy link
Author

sk2991 commented Apr 15, 2021

@hussainsaify I was not able to find any other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:auth kind:bug This is a clearly a bug
Projects
None yet
Development

No branches or pull requests

6 participants