Displaying "actual" try number in TaskInstance view

[SamWheating]

closes: #34309

Since we do some weird stuff with the try_number property, we have to do some weird stuff in order to properly search / display it in the UI 🥴:

1. Overriding try_number.expression so that sqlalchemy only sees the actual try_number value when searching or filtering.
2. Swapping in the prev_attempted_tries property in place of the try_number property in order to display the actual try_number value.

This causes the UI to function as expect, only showing + filtering on the actual value from the DB:

However, this feels pretty hacky and I think that overriding the hybrid_property expression in particular might cause some issues down the line. I am going to see how complicated it would be to remove the weird try_number property altogether, moving the try_number+1 logic to a separate property or selectively incrementing the value where required.

All feedback and suggestions welcome.

[potiuk]

docs need fixing for that one (and rebase).

[eladkal]

ping @SamWheating there is still time for this fix to be included in next release

[SamWheating]

Thanks for the bump, looking into this now 👀

How do you feel about the approach in general? It feels kinda hacky to me, but it technically works so 🤷

[eladkal]

How do you feel about the approach in general? It feels kinda hacky to me, but it technically works so

@bbovenzi approved so I guess it's OK :)

[bbovenzi]

How do you feel about the approach in general? It feels kinda hacky to me, but it technically works so

@bbovenzi approved so I guess it's OK :)

Yeah, if this gives the correct number then I'm happy with it. We should check that everywhere uses the right try_number.

[eladkal]

@bbovenzi can we merge it then?

[potiuk]

Merging :)