Fix constraints generation when there are no differences #36168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
fix-constraint-generation-failing
branch
from
eae7e67 to
7c1a17f
Compare
The new constraints generation implemented in apache#36158 had a bug that constraint files have not been generated when there was no changes (wrong file has been deleted). This resulted in PROD files generation failing when there were no new releases to one of 670 dependencies. This PR fixes it and improves the diagnostics of comstraints generation: * more information printed about generated files * using shorten method wnen running commands (will add ellipsis if longer) * failing when there are not constraints to upload - indicating a bug in the processs of constraints generation rather than when downloaded constraints are missing.
potiuk
force-pushed
the
fix-constraint-generation-failing
branch
from
7c1a17f to
4c3a0b4
Compare
potiuk
requested review from
Lee-W,
pankajkoti,
pierrejeambrun,
hussein-awala and
eladkal
potiuk
changed the title
potiuk
commented
Dec 11, 2023
| @@ -201,8 +204,8 @@ def diff_constraints(config_params: ConfigParams) -> None: | |||
| ) | |||
| if result.returncode == 0: | |||
| console.print("[green]No changes in constraints files. exiting") | |||
| config_params.current_constraints_file.unlink(missing_ok=True) | |||
| sys.exit(0) | |||
| config_params.constraints_diff_file.unlink(missing_ok=True) | |||
There was a problem hiding this comment.
This was the error. Wrong file was removed :(
amoghrajesh
approved these changes
Dec 11, 2023
vincbeck
approved these changes
Dec 11, 2023
hussein-awala
approved these changes
Dec 11, 2023
|
All works now :) 
|
potiuk
added a commit
that referenced
this pull request
Dec 15, 2023
The new constraints generation implemented in #36158 had a bug that constraint files have not been generated when there was no changes (wrong file has been deleted). This resulted in PROD files generation failing when there were no new releases to one of 670 dependencies. This PR fixes it and improves the diagnostics of comstraints generation: * more information printed about generated files * using shorten method wnen running commands (will add ellipsis if longer) * failing when there are not constraints to upload - indicating a bug in the processs of constraints generation rather than when downloaded constraints are missing. (cherry picked from commit 20a7f92)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new constraints generation implemented in #36158 had a bug that
constraint files have not been generated when there was no changes
(wrong file has been deleted). This resulted in PROD files generation
failing when there were no new releases to one of 670 dependencies.
This PR fixes it and improves the diagnostics of comstraints
generation:
longer)
a bug in the processs of constraints generation rather than when
downloaded constraints are missing.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.