Remove superfluous @Sentry.enrich_errors
#37002
Conversation
…le_downstream_tasks` A recent refactoring broke the contract `enrich_errors` expect. This decorator is being removed because it's not desired to log Sentry errors for scheduling issues.
I'd appreciate if someone could confirm my assumption |
|
@dirrao Thank you for taking a look. The static and mypy failure appear completely unrelated to this change, so I'm wondering if it should fall in the scope of this PR. Also, I couldn't reproduce the integration test failure locally so I'm wondering if a retry will resolve. |
If they unrelated, ignore them. However the retry should pass those test cases. |
jkramer-ginkgo
force-pushed
the
issue-36957
branch
from
fa41267
to
69256a7
Compare
|
Retry passed the integration test. Static/mypy checks are unrelated to this PR |
|
Let's see. Rebased the PR. For the future @jkramer-ginkgo - the best way to check failing checks is to rebase. Super easy in GitHub - with Rebase button. |
|
Yes. The MyPy issues are (somewhat) releated seems that your changes triggered it. Unfortunately MyPy checks are based on heuristics, and it sometimes only starts detecting issues after changes in loosely related places, I am afraid the only way for you to fix it, is to fix the detected error in your PR, even if you think it's not related. Courtesy of MyPy, there is not much we can do with it other than asking people who (rarely) hit this kind of issue - to fix it in their PR. |
Resolves MyPy error
jkramer-ginkgo
force-pushed
the
issue-36957
branch
from
242d3f4
to
f3905e6
Compare
* Remove superfluous `@Sentry.enrich_errors` from `TaskInstance._schedule_downstream_tasks` A recent refactoring broke the contract `enrich_errors` expect. This decorator is being removed because it's not desired to log Sentry errors for scheduling issues. * Fix incorrect parameter name Resolves MyPy error (cherry picked from commit 45b6b7a)
* Remove superfluous `@Sentry.enrich_errors` from `TaskInstance._schedule_downstream_tasks` A recent refactoring broke the contract `enrich_errors` expect. This decorator is being removed because it's not desired to log Sentry errors for scheduling issues. * Fix incorrect parameter name Resolves MyPy error (cherry picked from commit 45b6b7a)
Remove superfluous
@Sentry.enrich_errorsfromTaskInstance._schedule_downstream_tasksA recent refactoring broke the contract
enrich_errorsexpect. This decorator is being removed because it's not desired to log Sentry errors for scheduling issues.Closes: #36957
Closes: #36968 [this PR is an alternate implementation]