Fix bug with clicking url-unsafe tags #37395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patgarz
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
patgarz
force-pushed
the
urlsafe-tags
branch
from
cabfbd7
to
df33260
Compare
Lee-W
approved these changes
Feb 14, 2024
dirrao
approved these changes
Feb 14, 2024
bbovenzi
approved these changes
Feb 14, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 20, 2024
(cherry picked from commit 70603f7)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 70603f7)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the text input box, filtering DAGs on a tag with url-unsafe characters (for example,
#slack-channel) replaces the url-unsafe characters with their url encoded equivalents:/home?tags=%23slack-channelHowever when you click on a tag to filter, the tag is not urlencoded, which leads to an error: the url is translated to
/home#slack-channelwith the return messageNo matching DAG tags found.(as the browser does not know how to interpret#and?together, I assume).This fix ensures that clicking tags also url encodes them which causes
#hash-tagsand other special characters to work correctly when clicking tags to filter.