Enable the 'Is Active?' flag by default in user view #37507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ephraimbuddy,
bbovenzi,
jedcunningham and
jscheffl
dirrao
approved these changes
Feb 17, 2024
jscheffl
approved these changes
Feb 17, 2024
Taragolis
added a commit
to Taragolis/airflow
that referenced
this pull request
Feb 17, 2024
potiuk
pushed a commit
that referenced
this pull request
Feb 17, 2024
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 18, 2024
Since all the USER/ROLE related code moved to FAB, we should also move the user schema tests as well. Not having the tests in the provider code, made the apache#37507 succeed because of selective chekcs (false positive). Mobing the tests to fab provider should fix the problem.
potiuk
added a commit
that referenced
this pull request
Feb 18, 2024
Since all the USER/ROLE related code moved to FAB, we should also move the user schema tests as well. Not having the tests in the provider code, made the #37507 succeed because of selective chekcs (false positive). Mobing the tests to fab provider should fix the problem.
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While personally creating an user from the UI, I personally find it inconvenient to tick the checkbox for
Is Active?It would be nice to have this enabled by default so that users do not run into cases where they miss it
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.