Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing external_task_group_id to WorkflowTrigger #39617

Merged
merged 1 commit into from
May 14, 2024

Conversation

nathadfield
Copy link
Collaborator

Fixes an issue where deferred ExternalTaskSensors are not correctly waiting on a TaskGroup

closes: #39616

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label May 14, 2024
@nathadfield nathadfield marked this pull request as ready for review May 14, 2024 12:35
@nathadfield nathadfield requested a review from pankajastro May 14, 2024 12:35
Copy link
Member

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pankajastro pankajastro merged commit 7db851f into apache:main May 14, 2024
41 checks passed
@nathadfield nathadfield deleted the fix/external_task_sensor branch May 14, 2024 13:09
@utkarsharma2 utkarsharma2 added the type:improvement Changelog: Improvements label Jun 3, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.0 milestone Jun 3, 2024
@eladkal eladkal added type:bug-fix Changelog: Bug Fixes and removed type:improvement Changelog: Improvements labels Jul 16, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deferrable ExternalTaskSensor doesn't correctly wait on external_task_group_id
4 participants