Migrate public get dags to fastapi #42196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
commented
Sep 12, 2024
|
I like using the |
pierrejeambrun
force-pushed
the
migrate-dag-list-to-fastapi
branch
from
02efc72 to
2ba1d85
Compare
|
Looks like Test OpenAPI client CI is trying to fetch endpoints that we haven't built yet? |
Rebasing will fix that. We did a revert that caused that. I just merged the final revert. |
vincbeck
approved these changes
Sep 12, 2024
bbovenzi
force-pushed
the
migrate-dag-list-to-fastapi
branch
from
2ba1d85 to
3be2249
Compare
bbovenzi
approved these changes
Sep 12, 2024
pierrejeambrun
force-pushed
the
migrate-dag-list-to-fastapi
branch
from
3be2249 to
cdfa566
Compare
|
CI should be green now, it took some time but there was issues with |
|
Unrelated mypy failure on providers, merging |
1 task
pierrejeambrun
added
the
airflow3.0:breaking
|
Added the breaking label, because the Might remove later if we implement it. |
This comment was marked as resolved.
This comment was marked as resolved.
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* Migrate public get dags to fastapi * Fix CI * Fix CI lowest dependency resolution
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 22, 2024
The `eval-type-backport` is a tool to replace some of the controversial new type hints added with `from future imoport __annotations__` to "classic" type hint (| and list - into `Union` and `List`). This helps to battle some of the issues where Pydantic has troubles when they are used for classes that Pydantic uses. The library was initially added in apache#42196 but it was added for all Python versions - this change limits it only to Python < 3.10
This was referenced Nov 22, 2024
potiuk
added a commit
that referenced
this pull request
Nov 23, 2024
The `eval-type-backport` is a tool to replace some of the controversial new type hints added with `from future imoport __annotations__` to "classic" type hint (| and list - into `Union` and `List`). This helps to battle some of the issues where Pydantic has troubles when they are used for classes that Pydantic uses. The library was initially added in #42196 but it was added for all Python versions - this change limits it only to Python < 3.10
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 23, 2024
…e#44294) The `eval-type-backport` is a tool to replace some of the controversial new type hints added with `from future imoport __annotations__` to "classic" type hint (| and list - into `Union` and `List`). This helps to battle some of the issues where Pydantic has troubles when they are used for classes that Pydantic uses. The library was initially added in apache#42196 but it was added for all Python versions - this change limits it only to Python < 3.10 (cherry picked from commit 2948338) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
jscheffl
pushed a commit
that referenced
this pull request
Nov 24, 2024
… (#44315) The `eval-type-backport` is a tool to replace some of the controversial new type hints added with `from future imoport __annotations__` to "classic" type hint (| and list - into `Union` and `List`). This helps to battle some of the issues where Pydantic has troubles when they are used for classes that Pydantic uses. The library was initially added in #42196 but it was added for all Python versions - this change limits it only to Python < 3.10 (cherry picked from commit 2948338)
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 4, 2024
… (#44315) The `eval-type-backport` is a tool to replace some of the controversial new type hints added with `from future imoport __annotations__` to "classic" type hint (| and list - into `Union` and `List`). This helps to battle some of the issues where Pydantic has troubles when they are used for classes that Pydantic uses. The library was initially added in #42196 but it was added for all Python versions - this change limits it only to Python < 3.10 (cherry picked from commit 2948338)
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 9, 2024
… (#44315) The `eval-type-backport` is a tool to replace some of the controversial new type hints added with `from future imoport __annotations__` to "classic" type hint (| and list - into `Union` and `List`). This helps to battle some of the issues where Pydantic has troubles when they are used for classes that Pydantic uses. The library was initially added in #42196 but it was added for all Python versions - this change limits it only to Python < 3.10 (cherry picked from commit 2948338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #42159
This is the first step to get the endpoint we need. This add the
get_dagsendpoint in the public part of the fastapi API. This is iso functional in terms of feature as to what we have on the current public api. Only difference is that permissions are not yet handled we would need #42019.Also I removed for now the
fieldparam allowing for partial response of only subfields. This is a bit harder to handle and changes dynamically the response model of the endpoint. Also this does not improve much because the full object is already loaded by the ORM, we just save some serialization and response size. (endpoint is paginated anyway). We can work on that if we need it.A follow up PR will come to add new features to that endpoint as requested in the related issue to fulfill UI requirements.