Add fastapi migration done marker #42198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
ryanahamilton,
ashb,
bbovenzi,
jscheffl and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:API
bbovenzi
reviewed
Sep 12, 2024
pierrejeambrun
force-pushed
the
add-fastapi-migration-done-marker
branch
3 times, most recently
from
430d715 to
021881d
Compare
pierrejeambrun
force-pushed
the
add-fastapi-migration-done-marker
branch
from
021881d to
5095eb9
Compare
pierrejeambrun
force-pushed
the
add-fastapi-migration-done-marker
branch
from
5095eb9 to
c72ec3f
Compare
gopidesupavan
pushed a commit
to gopidesupavan/airflow
that referenced
this pull request
Sep 17, 2024
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of: #42196
You can just review the last commit. This is short one that add a no-op decorator to be able to mark endpoint as migrated over to the new FastAPI API.
The goal with this is to keep track of what is left to migrate and what is already migrated. There are a lot of endpoints and this will prevent maintainers from searching over the code base to get that information. The advantage of a decorator over docstring or comment is that it's code. (searchable by references, consistent in style, etc...).
Kind ask to contributors and reviewers of PR related to
AIP-84please enforce the usage of this marker on PRs migrating endpoints :).