Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84 Migrate the public endpoint DAG Details to FastAPI #42631

Merged
merged 10 commits into from
Oct 3, 2024

Conversation

omkar-foss
Copy link
Collaborator

Closes: #42453
Related: #42370

This migrates the Get DAG Details API from api_connexion to api_fastapi.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Oct 1, 2024
@omkar-foss omkar-foss force-pushed the aip-84/dags/get-dag-details branch from 7ab0093 to 5e5fabc Compare October 1, 2024 21:15
@pierrejeambrun pierrejeambrun changed the title Migrate the public endpoint DAG Details to FastAPI AIP-84 Migrate the public endpoint DAG Details to FastAPI Oct 2, 2024
@pierrejeambrun pierrejeambrun added the AIP-84 Modern Rest API label Oct 2, 2024
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A few suggestions but overall code looks good :)

airflow/api_fastapi/serializers/dags.py Show resolved Hide resolved
airflow/api_fastapi/serializers/dags.py Outdated Show resolved Hide resolved
airflow/api_fastapi/serializers/dags.py Outdated Show resolved Hide resolved
airflow/api_fastapi/serializers/dags.py Outdated Show resolved Hide resolved
airflow/api_fastapi/views/public/dags.py Outdated Show resolved Hide resolved
airflow/api_fastapi/views/public/dags.py Outdated Show resolved Hide resolved
airflow/api_fastapi/views/public/dags.py Outdated Show resolved Hide resolved
@omkar-foss omkar-foss force-pushed the aip-84/dags/get-dag-details branch from 5250a48 to 79ea68d Compare October 2, 2024 21:07
@omkar-foss
Copy link
Collaborator Author

omkar-foss commented Oct 2, 2024

Thanks for the PR! A few suggestions but overall code looks good :)

Thank you for the review! I've updated the PR as per your comments. All checks have passed and PR is ready for (re-)review.

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final UI types look good to me

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@bbovenzi bbovenzi merged commit b5712e7 into apache:main Oct 3, 2024
52 checks passed
@omkar-foss omkar-foss deleted the aip-84/dags/get-dag-details branch October 3, 2024 09:28
@omkar-foss omkar-foss restored the aip-84/dags/get-dag-details branch October 9, 2024 07:40
@omkar-foss omkar-foss deleted the aip-84/dags/get-dag-details branch October 9, 2024 07:43
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
* Migrate the public endpoint DAG Details to FastAPI

* Add comment for computed_field, remove unused import

* Update pendulum import path

* Re-run breeze static checks

* Add openapi-gen for DAG Details API

* Resolve review comments, test has_task_concurrency_limits

* Remove unused import

* Use lambda for aliases, re-run breeze static checks

* Remove duplicate entry

* Use simpler approach for alias
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Migrate the public endpoint DAG Details to FastAPI

* Add comment for computed_field, remove unused import

* Update pendulum import path

* Re-run breeze static checks

* Add openapi-gen for DAG Details API

* Resolve review comments, test has_task_concurrency_limits

* Remove unused import

* Use lambda for aliases, re-run breeze static checks

* Remove duplicate entry

* Use simpler approach for alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-84 Modern Rest API area:API Airflow's REST/HTTP API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIP-84 Migrate the public endpoint DAG Details to FastAPI
3 participants