-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84 Migrate the public endpoint DAG Details to FastAPI #42631
Conversation
7ab0093
to
5e5fabc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! A few suggestions but overall code looks good :)
5250a48
to
79ea68d
Compare
Thank you for the review! I've updated the PR as per your comments. All checks have passed and PR is ready for (re-)review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The final UI types look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks!
* Migrate the public endpoint DAG Details to FastAPI * Add comment for computed_field, remove unused import * Update pendulum import path * Re-run breeze static checks * Add openapi-gen for DAG Details API * Resolve review comments, test has_task_concurrency_limits * Remove unused import * Use lambda for aliases, re-run breeze static checks * Remove duplicate entry * Use simpler approach for alias
* Migrate the public endpoint DAG Details to FastAPI * Add comment for computed_field, remove unused import * Update pendulum import path * Re-run breeze static checks * Add openapi-gen for DAG Details API * Resolve review comments, test has_task_concurrency_limits * Remove unused import * Use lambda for aliases, re-run breeze static checks * Remove duplicate entry * Use simpler approach for alias
Closes: #42453
Related: #42370
This migrates the Get DAG Details API from
api_connexion
toapi_fastapi
.