Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84 Get Variable #42834

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

pierrejeambrun
Copy link
Member

Related to: #42370

Add delete_variable endpoint.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Oct 8, 2024
@pierrejeambrun pierrejeambrun added AIP-84 Modern Rest API legacy api Whether legacy API changes should be allowed in PR and removed area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Oct 8, 2024
@pierrejeambrun pierrejeambrun self-assigned this Oct 8, 2024
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

airflow/api_fastapi/openapi/v1-generated.yaml Show resolved Hide resolved
@bbovenzi
Copy link
Contributor

bbovenzi commented Oct 9, 2024

I know this is just copying the existing REST API. But I don't see any checks to try to hide sensitive variable values. Do we want to add that in?

@pierrejeambrun
Copy link
Member Author

I know this is just copying the existing REST API. But I don't see any checks to try to hide sensitive variable values. Do we want to add that in?

Good idea. I'm trying to see if I can incorporate that real quick, don't know why my test is failing at the moment.

@pierrejeambrun
Copy link
Member Author

Pushed. Test cases were updated.

Handle redacted value for Variables
@pierrejeambrun pierrejeambrun merged commit e2f2653 into apache:main Oct 9, 2024
52 checks passed
@pierrejeambrun pierrejeambrun deleted the get-variable-fastapi branch October 9, 2024 15:03
kunaljubce pushed a commit to kunaljubce/airflow that referenced this pull request Oct 13, 2024
Handle redacted value for Variables
pavansharma36 pushed a commit to pavansharma36/airflow that referenced this pull request Oct 14, 2024
Handle redacted value for Variables
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
Handle redacted value for Variables
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
Handle redacted value for Variables
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
Handle redacted value for Variables
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Handle redacted value for Variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-84 Modern Rest API legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants