-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84 Get Variable #42834
AIP-84 Get Variable #42834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I know this is just copying the existing REST API. But I don't see any checks to try to hide sensitive variable values. Do we want to add that in? |
Good idea. I'm trying to see if I can incorporate that real quick, don't know why my test is failing at the moment. |
Pushed. Test cases were updated. |
59a90f4
to
2a97470
Compare
Handle redacted value for Variables
2a97470
to
7e3a1ef
Compare
Handle redacted value for Variables
Handle redacted value for Variables
Handle redacted value for Variables
Handle redacted value for Variables
Handle redacted value for Variables
Handle redacted value for Variables
Related to: #42370
Add delete_variable endpoint.