-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84: Migrating DELETE queued asset events for DAG to fastAPI #44129
Merged
pierrejeambrun
merged 8 commits into
apache:main
from
astronomer:AIP84-delete-all-queued-events-for-dag-again
Nov 18, 2024
Merged
AIP-84: Migrating DELETE queued asset events for DAG to fastAPI #44129
pierrejeambrun
merged 8 commits into
apache:main
from
astronomer:AIP84-delete-all-queued-events-for-dag-again
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
added
the
legacy api
Whether legacy API changes should be allowed in PR
label
Nov 18, 2024
amoghrajesh
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
November 18, 2024 08:41
boring-cyborg
bot
added
area:API
Airflow's REST/HTTP API
area:UI
Related to UI/UX. For Frontend Developers.
labels
Nov 18, 2024
amoghrajesh
changed the title
Aip84 delete all queued events for dag again
AIP-84: Migrating delete queued asset events for DAG to fastAPI
Nov 18, 2024
This was referenced Nov 18, 2024
rawwar
reviewed
Nov 18, 2024
amoghrajesh
changed the title
AIP-84: Migrating delete queued asset events for DAG to fastAPI
AIP-84: Migrating DELETE queued asset events for DAG to fastAPI
Nov 18, 2024
Lee-W
requested changes
Nov 18, 2024
Lee-W
approved these changes
Nov 18, 2024
pierrejeambrun
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
pierrejeambrun
deleted the
AIP84-delete-all-queued-events-for-dag-again
branch
November 18, 2024 13:57
amoghrajesh
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 18, 2024
…he#44129) * AIP-84: Migrating GET queued asset events for DAG to fastAPI * fixing tests and server code * fixing parameters * fixing parameters * AIP-84: Migrating delete queued asset events for DAG to fastAPI * adding assert for count * review comments from kalyan
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
…he#44129) * AIP-84: Migrating GET queued asset events for DAG to fastAPI * fixing tests and server code * fixing parameters * fixing parameters * AIP-84: Migrating delete queued asset events for DAG to fastAPI * adding assert for count * review comments from kalyan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:API
Airflow's REST/HTTP API
area:UI
Related to UI/UX. For Frontend Developers.
legacy api
Whether legacy API changes should be allowed in PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #42370
Migrating delete queued asset events for DAG to fastAPI
Dependent on #44124
Same setup as #44124
Responses:
Legacy
FastAPI
With time filtering
Legacy
FastAPI
Time filtering but no queued event found
Legacy
FastAPI
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.