Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "/" at end from FastAPI endpoints routes #44218

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

rawwar
Copy link
Collaborator

@rawwar rawwar commented Nov 20, 2024

Removing trailing "/" from routes to be inline with legacy endpoints

related to #42370

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 20, 2024
@rawwar rawwar changed the title remove / from FastAPI endpoints remove "/" at end from FastAPI endpoints Nov 20, 2024
@rawwar rawwar changed the title remove "/" at end from FastAPI endpoints remove "/" at end from FastAPI endpoints routes Nov 20, 2024
@rawwar rawwar marked this pull request as ready for review November 20, 2024 16:31
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good thanks.

Tests need fixing.

@pierrejeambrun pierrejeambrun merged commit 8831b31 into apache:main Nov 20, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants