Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate public endpoint Patch Task Instance to FastAPI #44223

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Migrate public endpoint Patch Task Instance to FastAPI #44223

merged 3 commits into from
Nov 26, 2024

Conversation

omkar-foss
Copy link
Collaborator

@omkar-foss omkar-foss commented Nov 20, 2024 •
edited
Loading

closes: #43753, #43754 and #43752
related: #42370

This migrates the Patch Task Instance API from api_connexion to api_fastapi.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 20, 2024
@omkar-foss omkar-foss self-assigned this Nov 20, 2024
@omkar-foss omkar-foss added the legacy api Whether legacy API changes should be allowed in PR label Nov 20, 2024
@omkar-foss omkar-foss closed this Nov 20, 2024
@omkar-foss omkar-foss reopened this Nov 20, 2024
@omkar-foss omkar-foss mentioned this pull request Nov 20, 2024
Closed
2 tasks
@omkar-foss omkar-foss marked this pull request as ready for review November 20, 2024 19:50
@omkar-foss
Copy link
Collaborator Author

All checks passed, PR is ready for review ✅

@omkar-foss
Copy link
Collaborator Author

@pierrejeambrun I'm adding the Set Task Instance Note functionality to this (Patch Task Instance) API as you mentioned here. Will update this PR in a while.

pierrejeambrun
pierrejeambrun reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to include the update_mask as we do for other patch endpoints. (The state part would actually be the set_task_instance_state of your other PR)

airflow/api_fastapi/core_api/datamodels/task_instances.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/task_instances.py Show resolved Hide resolved
@bbovenzi bbovenzi mentioned this pull request Nov 21, 2024
Closed
@omkar-foss
Copy link
Collaborator Author

I think we need to include the update_mask as we do for other patch endpoints. (The state part would actually be the set_task_instance_state of your other PR)

@pierrejeambrun I've added update_mask here in this PR to Patch Task Instance API.

Yes got it, sure, I've closed the other Set Task Instance State PR #44246.

@omkar-foss omkar-foss force-pushed the aip-84/tis/patch-ti branch 3 times, most recently from a1a6f18 to fcb6ea5 Compare November 22, 2024 14:43
@omkar-foss
Copy link
Collaborator Author

All conversations resolved, PR rebased with main and all conflicts resolved, please have a look when possible @pierrejeambrun @bbovenzi. Thanks.

@omkar-foss omkar-foss force-pushed the aip-84/tis/patch-ti branch 2 times, most recently from 40d4fad to fc0fdff Compare November 25, 2024 16:46
@omkar-foss
Copy link
Collaborator Author

@pierrejeambrun all checks passing, and have rebased with main just now. Please review when you get a chance, thanks.

pierrejeambrun
pierrejeambrun approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments.

Looking good, ready to merge after that.

tests/api_fastapi/core_api/routes/public/test_task_instances.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_task_instances.py Outdated Show resolved Hide resolved
@omkar-foss
Copy link
Collaborator Author

@pierrejeambrun PR rebased with main and ready to merge. Thank you.

@pierrejeambrun pierrejeambrun merged commit a832c41 into apache:main Nov 26, 2024
62 checks passed
@pierrejeambrun pierrejeambrun mentioned this pull request Nov 26, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees

@omkar-foss omkar-foss

Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-84 Patch Task Instance
3 participants
@omkar-foss @Kludex @pierrejeambrun