Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add the document of backend E2E environment #1380

Closed
Jaycean opened this issue Jan 27, 2021 · 3 comments · Fixed by #1381
Closed

Doc: Add the document of backend E2E environment #1380

Jaycean opened this issue Jan 27, 2021 · 3 comments · Fixed by #1381
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@Jaycean
Copy link
Member

Jaycean commented Jan 27, 2021

Feature request

Please describe your feature

  • In the process of submitting my contribution, I found that there was no local documentation for setting up E2E test environment, and I didn't know how to conduct E2E test locally. I could only view the results of GitHub Ci by submitting code, which was very unfriendly. So I checked the command of GitHub Ci and found that I needed to run docker upstream locally

Describe the solution you'd like

  • I want to submit a PR update doc, so that more developers can quickly develop for the first time and use E2E test locally.
docker run -d --name upstream -v /home/apisix-dashboard/api/test/docker/upstream.conf:/etc/nginx/conf.d/default.conf:ro -p 80:80 -p 1980:1980 -p 1981:1981 -p 1982:1982 -p 1983:1983 -p 1984:1984 johz/upstream:v2.0
@imjoey
Copy link
Member

imjoey commented Jan 27, 2021

@Jaycean good catch. I believe that would be very helpful for every contributor. Your PR is greatly welcome. Thanks.

@imjoey imjoey added the documentation Improvements or additions to documentation label Jan 27, 2021
@juzhiyuan
Copy link
Member

cc @starsz @LiteSun to know this tip.

@starsz
Copy link
Contributor

starsz commented Jan 28, 2021

Can't agree anymore. 😄

@imjoey imjoey added this to the 2.4 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants