Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The upstream timeout unit is seconds instead of milliseconds #1565

Closed
dickens7 opened this issue Mar 9, 2021 · 9 comments · Fixed by #1580
Closed

The upstream timeout unit is seconds instead of milliseconds #1565

dickens7 opened this issue Mar 9, 2021 · 9 comments · Fixed by #1580
Assignees
@stu01509
Labels
bug Something isn't working frontend good first issue Good for newcomers

Comments

@dickens7
Copy link
Contributor

dickens7 commented Mar 9, 2021

image
@dickens7 dickens7 added the bug Something isn't working label Mar 9, 2021
@nic-chen
Copy link
Member

nic-chen commented Mar 9, 2021

thanks for feedback, we will recheck it.

@juzhiyuan
Copy link
Member

@nic-chen any update about this? should it be seconds or milliseconds?

@nic-chen
Copy link
Member

nic-chen commented Mar 9, 2021

@juzhiyuan it's in seconds. see:

https://github.com/apache/apisix/blob/master/apisix/balancer.lua#L108
https://github.com/apache/apisix/blob/master/apisix/balancer.lua#L23

https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/balancer.md#set_timeouts

@juzhiyuan
Copy link
Member

OK

@LiteSun LiteSun added the good first issue Good for newcomers label Mar 10, 2021
@stu01509
Copy link
Contributor

I want to fix this issue, please assign this issue to me.

@nic-chen
Copy link
Member

ok, thanks. @stu01509

@iamayushdas
Copy link
Contributor

@stu01509 have you resolved the issue. if not then i would like to work on it
@nic-chen

@nic-chen
Copy link
Member

ping @stu01509

@stu01509 stu01509 mentioned this issue Mar 12, 2021
Merged
4 tasks
@stu01509
Copy link
Contributor

Hi @nic-chen sir

I sent the PR, Please review it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stu01509 stu01509

Labels
bug Something isn't working frontend good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix the upstream timeout unit
6 participants
@juzhiyuan @stu01509 @LiteSun @nic-chen @iamayushdas @dickens7