Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a problem with the dashboard display #1959

Closed
zuiyangqingzhou opened this issue Jun 30, 2021 · 7 comments · Fixed by #1963
Closed

There is a problem with the dashboard display #1959

zuiyangqingzhou opened this issue Jun 30, 2021 · 7 comments · Fixed by #1963
Labels
bug Something isn't working

Comments

@zuiyangqingzhou
Copy link

Issue description

On the upstream service settings page of the dashboard, there is a health check-unhealthy setting. One of the options is the timeout period. This is wrong. This option should be the number of unhealthy statuses.

As shown below

image

Expected behavior

How to Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots

Environment

  • apisix version (cmd: apisix version):
  • OS (cmd: uname -a):
  • OpenResty / Nginx version (cmd: nginx -V or openresty -V):
  • etcd version, if have (cmd: run curl http://127.0.0.1:9090/v1/server_info to get the info from server-info API):
  • apisix-dashboard version, if have: 2.7
  • Browser version, if have:

Additional context

@zuiyangqingzhou zuiyangqingzhou added the bug Something isn't working label Jun 30, 2021
@iamayushdas
Copy link
Contributor

iamayushdas commented Jun 30, 2021

looking into it , wait for a while, thank you for your time @zuiyangqingzhou

@iamayushdas
Copy link
Contributor

yes you are right @zuiyangqingzhou i just checked this, @juzhiyuan what's you opinion on this

@juzhiyuan
Copy link
Member

image

https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L196-L200

Hi, I just searched the schema_def file, and this field is existed indeed, which part is incorrect? @iamayushdas @zuiyangqingzhou

@zuiyangqingzhou
Copy link
Author

Are you sure that the configuration here refers to the timeout period? Instead of referring to the number of timeouts? If it is indeed a timeout, I have two questions, which are explained in the picture below

image

There is also a small question, is there something wrong with this display?

image

@juzhiyuan
Copy link
Member

https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L146-L168

@zuiyangqingzhou Dashboard's fields are according to above schema_def file, there doesn't have active.health.timeouts field.

image

This is an i18n issue, @guoqqqi could fix this.

@zuiyangqingzhou
Copy link
Author

Okay, I'll go to the apisix project to ask

@liuxiran
Copy link
Contributor

Since the dashboard I18n has been modified by #1963 , close this issue now.

And for the details about timeouts please refer issue: apache/apisix#4528

Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants