Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support appending query string in redirect plugin #2095

Open
liuxiran opened this issue Aug 26, 2021 · 7 comments
Open

Feature request: support appending query string in redirect plugin #2095

liuxiran opened this issue Aug 26, 2021 · 7 comments
Labels
Milestone

Comments

@liuxiran
Copy link
Contributor

Feature request

Please describe your feature

Dashboard has integrated the redirect plugin into the first step of Route creation, refer to apache/apisix#4298, it would be better to add append_query_string field

Describe the solution you'd like

@liuxiran liuxiran modified the milestones: 2.7.2, 2.9 Aug 26, 2021
@github-actions
Copy link

github-actions bot commented Nov 6, 2021

This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 6, 2021
@bzp2010 bzp2010 added good first issue Good for newcomers and removed stale labels Nov 8, 2021
@namangirdhar16
Copy link

Hi @liuxiran @bzp2010 i would like to work on this issue, please assign this to me.

@zaunist
Copy link
Contributor

zaunist commented Dec 16, 2021

Hi, @namangirdhar16 .Did you have any difficulties?

@juzhiyuan
Copy link
Member

@zaunist could you help to check this?

@zaunist
Copy link
Contributor

zaunist commented Dec 16, 2021

@zaunist could you help to check this?

A great pleasure

@zaunist
Copy link
Contributor

zaunist commented Dec 17, 2021

I checked redirect plugin, Only one of http_to_https, uri or regex_uri can be specified., but append_query_string not one of them. So append_query_string maybe a separate button or option menu, because append_query_string can coexist with http_to_https, uri, regex_uri. Is it right ?

@juzhiyuan
Copy link
Member

I checked redirect plugin, Only one of http_to_https, uri or regex_uri can be specified., but append_query_string not one of them. So append_query_string maybe a separate button or option menu, because append_query_string can coexist with http_to_https, uri, regex_uri. Is it right ?

Yes, both append_query_string & encode_uri are two seprate buttons, we could use Switch component to handle this.

@zaunist zaunist removed their assignment Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants