Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question #62 whether Apisix version 2.12 can be implemented? #67

Closed
rampagecong opened this issue Feb 17, 2022 · 7 comments
Closed

Question #62 whether Apisix version 2.12 can be implemented? #67

rampagecong opened this issue Feb 17, 2022 · 7 comments

Comments

@rampagecong
Copy link
Contributor

Issue description

Can #62 be implemented if you rewrite apisix-go-plugin-runne yourself? The technical plan for the company project should be made. If it can't be realized, the technical plan can only be changed.

Environment

  • APISIX Go Plugin Runner's version:
  • APISIX version:
  • Go version:
  • OS (cmd: uname -a):
@spacewander
Copy link
Member

It requires modifying APISIX. Are you interested in working on it?

@rampagecong
Copy link
Contributor Author

It requires modifying APISIX. Are you interested in working on it?
Very interested, but what skills are required.

@spacewander
Copy link
Member

@rampagecong
Copy link
Contributor Author

Ok.I'll try it.thanks.

@rampagecong
Copy link
Contributor Author

rampagecong commented Feb 22, 2022

Could you please take a look at those commits that implement the response header setting:
rampagecong@d498697
rampagecong/ext-plugin-proto@0fc113f
rampagecong/apisix@83d5057
I basically just add a resp_headers field to Req and Rewrite struct and regen the code.
Modified the FetchChanges method so that I can get the modified response header from the respHdr filed that I added to flatbuffer pb file.
@spacewander

@spacewander
Copy link
Member

spacewander commented Feb 23, 2022

Good. Could you submit them as Pull Request so that I can review them?

@spacewander
Copy link
Member

Already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants