Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request help: when upstream_type is chash, set_more_tries() make no sense. #2770

Closed
kai08-cn opened this issue Nov 17, 2020 · 1 comment
Closed

request help: when upstream_type is chash, set_more_tries() make no sense. #2770

kai08-cn opened this issue Nov 17, 2020 · 1 comment

Comments

@kai08-cn
Copy link
Contributor

Issue description

when upstream_type is chash, if last picked server does not work, apisix won't pick next server because of the unchanged chash_key, which make the function set_more_tries() to be meaningless.
is there any problem with this? how about using picker:next(last_id) to choose next server?

Environment

  • apisix version (cmd: apisix version): 2.0
  • OS: CentOS 7.4
@kai08-cn kai08-cn changed the title bug: when upstream_type is chash, set_more_tries() make no sense. request help: when upstream_type is chash, set_more_tries() make no sense. Nov 17, 2020
@spacewander
Copy link
Member

PR: #2676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spacewander @kai08-cn