You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#4152 supports redirect with regex, but 1. it does not append the query string from original request to the Location header, and 2. it does not encode url. I suggest fxing these as in proxy-rewrite. If everyone agrees on this I'll create a PR for the change.
Concerns
Proposed changes do change the behavior of current implementation, and it will cause problems if
someone expects the query string to be removed, or
someone encodes url manually in plugin configuration, e.g. "regex_uri": ["/abc(.*)", "/ab%20c$1"],
The text was updated successfully, but these errors were encountered:
Proposed changes
#4152 supports redirect with regex, but 1. it does not append the query string from original request to the Location header, and 2. it does not encode url. I suggest fxing these as in proxy-rewrite. If everyone agrees on this I'll create a PR for the change.
Concerns
Proposed changes do change the behavior of current implementation, and it will cause problems if
"regex_uri": ["/abc(.*)", "/ab%20c$1"],
The text was updated successfully, but these errors were encountered: