-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release 2.10.3 #5985
feat: release 2.10.3 #5985
Conversation
@juzhiyuan They will be pushed to a different branch. The use of this PR for pushing to master branch can be found in the following PR. In this release, some of the changes involved in the following PR [1] will be split into two parts to prevent affecting the master branch code. [1] #5508 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge this changelog will confuse the user about the timeline. Those fixes are in 2.10.3 but not in 2.11.0. Also, when we release 2.12.0, we have to mention some of those fixes again.
And this PR doesn't update the Chinese version of CHANGELOG.
Hi, @spacewander. I understand what you said, which may cause confusion to users. I added a partial description of what PRs were merged into this "LTS maintenance release" for version 2.10.3 as shown below, does this ease the confusion? Or do I need to remove CHANGELOG and make it provide only in the 2.10 branch. (But a CHANGELOG in the master branch is also need? How should I do it?) Also, I have added the Chinese version of CHANGELOG. |
@bzp2010 |
@@ -0,0 +1,95 @@ | |||
-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we don't need to archive this rockspec? We don't merge the code into the default branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spacewander Here it is marked for installation using the 2.10.3
git tag, as far as I know this could potentially be used when packaging various container images?
So, IMO, we need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @spacewander. Do I need to make changes for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see.
What this PR does / why we need it:
Update
rockspec
andCHANGELOG
for version 2.10.3. And updates related to version code and documentation will be provided in the PR ofrelease/2.10
to prevent affecting the master branch.Pre-submission checklist: