Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable timed dependant tests #54

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

kanavin
Copy link

@kanavin kanavin commented Feb 28, 2024

The disabled tests rely on timing to pass correctly. On a virtualized system under heavy load, these tests randomly fail because they miss a timer or other timing related issues.

@notroj
Copy link
Contributor

notroj commented Aug 6, 2024

Thanks for the PR. This looks like a good idea but I think it should be done with a plain AC_DEFINE(HAVE_xxx) rather than putting something in apr.h which becomes part of the API.

@kanavin
Copy link
Author

kanavin commented Aug 12, 2024

Thanks for the PR. This looks like a good idea but I think it should be done with a plain AC_DEFINE(HAVE_xxx) rather than putting something in apr.h which becomes part of the API.

This has been corrected now.

The disabled tests rely on timing to pass correctly. On a virtualized
system under heavy load, these tests randomly fail because they miss
a timer or other timing related issues.

Signed-off-by: Jeremy Puhlman <jpuhlman@mvista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants