Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[object_store] Support generating and using signed upload URLs #4763

Closed
carols10cents opened this issue Sep 1, 2023 · 9 comments · Fixed by #4876
Closed

[object_store] Support generating and using signed upload URLs #4763

carols10cents opened this issue Sep 1, 2023 · 9 comments · Fixed by #4876
Assignees
Labels
object-store Object Store Interface

Comments

@carols10cents
Copy link
Contributor

IOx needs the ability to ask object storage for a signed URL that can be then used for a PUT request to upload a file to a particular path.

This is related to, but slightly different from #3027, which is for generating signed URLs for GET requests to read particular files. (it might be easy enough to add that functionality when this ticket is done.

@tustvold
Copy link
Contributor

tustvold commented Sep 1, 2023

I wonder if we might add this functionality to AwsAuthorizer. Perhaps as a sign method to go alongside the authorize?

Eventually we could potentially extract a trait, and provide similar abstractions for all remote stores. I'm mainly just thinking it probably doesn't make sense to bundle this into the ObjectStore trait when many stores it won't make sense for.

@carols10cents
Copy link
Contributor Author

Sure, sounds good!

@alamb
Copy link
Contributor

alamb commented Sep 18, 2023

@carols10cents and @stuartcarnie -- is this feature needed for anything "near term" in IOx? @tustvold and I are trying to make sure it is prioritized correctly.

@carols10cents
Copy link
Contributor Author

@alamb Yes, it's needed for bulk migration: https://github.com/influxdata/influxdb_iox/issues/10370

@alamb
Copy link
Contributor

alamb commented Sep 18, 2023

@tustvold has put this item on his list

1 similar comment
@alamb
Copy link
Contributor

alamb commented Sep 18, 2023

@tustvold has put this item on his list

@carols10cents
Copy link
Contributor Author

Ooooh does that mean you're going to do it for me @tustvold ??? 🤩

@tustvold
Copy link
Contributor

Potentially if you don't get to it first, my list is depressingly long... 😅

@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'object-store'} from influxdata/idpe#4876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants