Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[object_store] minor bug: typos present in local variable #5628

Closed
Silemo opened this issue Apr 11, 2024 · 2 comments · Fixed by #5629
Closed

[object_store] minor bug: typos present in local variable #5628

Silemo opened this issue Apr 11, 2024 · 2 comments · Fixed by #5629
Labels
bug object-store Object Store Interface

Comments

@Silemo
Copy link
Contributor

Silemo commented Apr 11, 2024

Describe the bug

In the object_store/gcp folder, few of the files contain some minor typos.

To Reproduce

Search in the following files the respective terms:

  • object_store/gcp/builder.rs :
    • signing_cedentials (it should be signing_credentials);
  • object_store/gcp/client.rs :
    • repsonse (it should be response);
  • object_store/gcp/credentials.rs :
    • methond (it should be method ),
    • canaonical_headers (it should be canonical_headers),
    • caninical_request (it should be canonical_request)

Expected behavior

The code works smoothly as expected, it is just written incorrectly on a grammar level.

Additional context

I just opened a PR to fix these small typos. I created the issue for clarity as requested in the PR template.

@Xuanwo
Copy link
Member

Xuanwo commented Apr 11, 2024

Maybe we can introduce typos in CI.

@tustvold tustvold added the object-store Object Store Interface label Apr 17, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'object-store'} from #5629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants