Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Rustdocs are clean (amd64, nightly)" CI check is failing #5725

Closed
Jefffrey opened this issue May 6, 2024 · 4 comments · Fixed by #5727
Closed

"Rustdocs are clean (amd64, nightly)" CI check is failing #5725

Jefffrey opened this issue May 6, 2024 · 4 comments · Fixed by #5727
Labels
arrow Changes to the arrow crate bug help wanted parquet Changes to the parquet crate

Comments

@Jefffrey
Copy link
Contributor

Jefffrey commented May 6, 2024

Describe the bug

CI failing on unrelated PRs: https://github.com/apache/arrow-rs/actions/runs/8956610392/job/24627590071?pr=5679

    Checking parquet v51.0.0 (/__w/arrow-rs/arrow-rs/parquet)
warning: unexpected `cfg` condition name: `rustfmt`
 --> parquet/src/format.rs:8:13
  |
8 | #![cfg_attr(rustfmt, rustfmt_skip)]
  |             ^^^^^^^
  |
  = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, `windows`
  = help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(rustfmt)");` to the top of the `build.rs`
  = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
  = note: `#[warn(unexpected_cfgs)]` on by default

    Checking tracing-log v0.2.0
    Checking tonic v0.11.0
    Checking arrow v51.0.0 (/__w/arrow-rs/arrow-rs/arrow)
 Documenting parquet v51.0.0 (/__w/arrow-rs/arrow-rs/parquet)
    Checking hex v0.4.3
error: unexpected `cfg` condition name: `rustfmt`
 --> parquet/src/format.rs:8:13
  |
8 | #![cfg_attr(rustfmt, rustfmt_skip)]
  |             ^^^^^^^
  |
  = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, `windows`
  = help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(rustfmt)");` to the top of the `build.rs`
  = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
  = note: `-D unexpected-cfgs` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`

error: could not document `parquet`
warning: build failed, waiting for other jobs to finish...
warning: `parquet` (lib) generated 1 warning

To Reproduce

Run CI

Expected behavior

CI succeeds for this check

Additional context

Related issue: rust-lang/rust#124735

@alamb
Copy link
Contributor

alamb commented May 6, 2024

Thanks you for filing this @Jefffrey

@alamb
Copy link
Contributor

alamb commented May 6, 2024

Proposed PR to fix: #5727

@tustvold tustvold added the parquet Changes to the parquet crate label May 10, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'parquet'} from #5727

@tustvold tustvold added the arrow Changes to the arrow crate label May 10, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #5727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug help wanted parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants