Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy fails on main after upgrade to rust 1.80 #6114

Closed
alamb opened this issue Jul 25, 2024 · 1 comment · Fixed by #6116
Closed

Clippy fails on main after upgrade to rust 1.80 #6114

alamb opened this issue Jul 25, 2024 · 1 comment · Fixed by #6116
Assignees
@alamb
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs

Comments

@alamb
Copy link
Contributor

alamb commented Jul 25, 2024

Describe the bug

Clippy and docs started failing on main today:
fa2fbfd

This is almost certainly due to the new rust release today adding more stringent clippy lints: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-180-2024-07-25

Example failures:
https://github.com/apache/arrow-rs/actions/runs/10098403310/job/27925376175
https://github.com/apache/arrow-rs/actions/runs/10098403321/job/27925373718
https://github.com/apache/arrow-rs/actions/runs/10098403299/job/27925376404

To Reproduce
Run clippy / docs locally

Expected behavior
SHould pass

Additional context
@alamb alamb added the bug label Jul 25, 2024
@alamb alamb self-assigned this Jul 25, 2024
@alamb
Copy link
Contributor Author

alamb commented Jul 25, 2024

I will fix this

@alamb alamb changed the title Clippy fails on main Clippy fails on main after upgrade to rust 1.80 Jul 25, 2024
@alamb alamb mentioned this issue Jul 25, 2024
Merged
@alamb alamb added arrow Changes to the arrow crate development-process Related to development process of arrow-rs and removed bug labels Jul 25, 2024
@alamb alamb mentioned this issue Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alamb alamb

Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Clippy for the Rust 1.80 release alamb/arrow-rs
1 participant
@alamb